Commit 09a81a0f authored by Ankit Garg's avatar Ankit Garg Committed by Jakub Kicinski
Browse files

gve: Default to max_rx_buffer_size for DQO if device supported 



Change the driver's default behavior to prefer the largest available RX
buffer length supported by the device for DQO format, rather than always
using the hardcoded 2K default.

Previously, the driver would initialize with
`GVE_DEFAULT_RX_BUFFER_SIZE` (2K), even if the device advertised support
for a larger length (e.g., 4K).

Performance observations:
- With LRO disabled, we observed >10% improvement in RX single stream
throughput when MTU >=2048.
- With LRO enabled, we observed >10% improvement in RX single stream
throughput when MTU >=1460.
- No regressions were observed.

Signed-off-by: default avatarAnkit Garg <nktgrg@google.com>
Reviewed-by: default avatarHarshitha Ramamurthy <hramamurthy@google.com>
Reviewed-by: default avatarJordan Rhee <jordanrhee@google.com>
Reviewed-by: default avatarWillem de Bruijn <willemb@google.com>
Signed-off-by: default avatarJoshua Washington <joshwash@google.com>
Link: https://patch.msgid.link/20251106192746.243525-5-joshwash@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent d235bb21

drivers/net/ethernet/google/gve/gve_adminq.c

+4 −0
Original line number Diff line number Diff line
@@ -987,6 +987,10 @@ static void gve_enable_supported_features(struct gve_priv *priv, 
		dev_info(&priv->pdev->dev,

			 "BUFFER SIZES device option enabled with max_rx_buffer_size of %u, header_buf_size of %u.\n",

			 priv->max_rx_buffer_size, priv->header_buf_size);

		if (gve_is_dqo(priv) &&

		    priv->max_rx_buffer_size > GVE_DEFAULT_RX_BUFFER_SIZE)

			priv->rx_cfg.packet_buffer_size =

				priv->max_rx_buffer_size;

	}



	/* Read and store ring size ranges given by device */