Commit 09beefef authored by Michael Kelley's avatar Michael Kelley Committed by Wei Liu
Browse files

x86/hyperv: Fix output argument to hypercall that changes page visibility 



The hypercall in hv_mark_gpa_visibility() is invoked with an input
argument and an output argument. The output argument ostensibly returns
the number of pages that were processed. But in fact, the hypercall does
not provide any output, so the output argument is spurious.

The spurious argument is harmless because Hyper-V ignores it, but in the
interest of correctness and to avoid the potential for future problems,
remove it.

Signed-off-by: default avatarMichael Kelley <mhklinux@outlook.com>
Reviewed-by: default avatarNuno Das Neves <nunodasneves@linux.microsoft.com>
Link: https://lore.kernel.org/r/20250226200612.2062-2-mhklinux@outlook.com


Signed-off-by: default avatarWei Liu <wei.liu@kernel.org>
Message-ID: <20250226200612.2062-2-mhklinux@outlook.com>
parent ea2f45ab

arch/x86/hyperv/ivm.c

+1 −2
Original line number Diff line number Diff line
@@ -464,7 +464,6 @@ static int hv_mark_gpa_visibility(u16 count, const u64 pfn[], 
			   enum hv_mem_host_visibility visibility)

{

	struct hv_gpa_range_for_visibility *input;

	u16 pages_processed;

	u64 hv_status;

	unsigned long flags;
@@ -493,7 +492,7 @@ static int hv_mark_gpa_visibility(u16 count, const u64 pfn[], 
	memcpy((void *)input->gpa_page_list, pfn, count * sizeof(*pfn));

	hv_status = hv_do_rep_hypercall(

			HVCALL_MODIFY_SPARSE_GPA_PAGE_HOST_VISIBILITY, count,

			0, input, &pages_processed);

			0, input, NULL);

	local_irq_restore(flags);



	if (hv_result_success(hv_status))