Commit 09d3b7a1 authored by Ratheesh Kannoth's avatar Ratheesh Kannoth Committed by Jakub Kicinski
Browse files

octeontx2-af: npc: cn20k: Allocate default MCAM indexes 



Reserving MCAM entries in the AF driver for installing default MCAM
entries is not an efficient allocation method, as it results in
significant wastage of entries. This patch allocates MCAM indexes for
promiscuous, multicast, broadcast, and unicast traffic in descending
order of indexes (from lower to higher priority) when the NIX LF is
attached to the PF/VF.

Signed-off-by: default avatarRatheesh Kannoth <rkannoth@marvell.com>
Link: https://patch.msgid.link/20260224080009.4147301-6-rkannoth@marvell.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ef992a0f

drivers/net/ethernet/marvell/octeontx2/af/cn20k/npc.c

+361 −0
Original line number Diff line number Diff line
@@ -25,10 +25,28 @@ static const char *npc_kw_name[NPC_MCAM_KEY_MAX] = { 
	[NPC_MCAM_KEY_X4] = "X4",

};



static const char *npc_dft_rule_name[NPC_DFT_RULE_MAX_ID] = {

	[NPC_DFT_RULE_PROMISC_ID] = "Promisc",

	[NPC_DFT_RULE_MCAST_ID] = "Mcast",

	[NPC_DFT_RULE_BCAST_ID] = "Bcast",

	[NPC_DFT_RULE_UCAST_ID] = "Ucast",

};



#define KEX_EXTR_CFG(bytesm1, hdr_ofs, ena, key_ofs)		\

		     (((bytesm1) << 16) | ((hdr_ofs) << 8) | ((ena) << 7) | \

		     ((key_ofs) & 0x3F))



#define NPC_DFT_RULE_ID_MK(pcifunc, id) \

	((pcifunc) | FIELD_PREP(GENMASK_ULL(31, 16), id))



#define NPC_DFT_RULE_ID_2_PCIFUNC(rid) \

	FIELD_GET(GENMASK_ULL(15, 0), rid)



#define NPC_DFT_RULE_ID_2_ID(rid) \

	FIELD_GET(GENMASK_ULL(31, 16), rid)



#define NPC_DFT_RULE_PRIO 127



static const char cn20k_def_pfl_name[] = "default";



static struct npc_mcam_kex_extr npc_mkex_extr_default = {
@@ -2380,6 +2398,346 @@ static int npc_pcifunc_map_create(struct rvu *rvu) 
	return cnt;

}



int npc_cn20k_dft_rules_idx_get(struct rvu *rvu, u16 pcifunc, u16 *bcast,

				u16 *mcast, u16 *promisc, u16 *ucast)

{

	u16 *ptr[4] = {promisc, mcast, bcast, ucast};

	unsigned long idx;

	bool set = false;

	void *val;

	int i, j;



	if (!npc_priv.init_done)

		return 0;



	if (is_lbk_vf(rvu, pcifunc)) {

		if (!ptr[0])

			return -EINVAL;



		idx = NPC_DFT_RULE_ID_MK(pcifunc, NPC_DFT_RULE_PROMISC_ID);

		val = xa_load(&npc_priv.xa_pf2dfl_rmap, idx);

		if (!val) {

			pr_debug("%s: Failed to find %s index for pcifunc=%#x\n",

				 __func__,

				 npc_dft_rule_name[NPC_DFT_RULE_PROMISC_ID],

				 pcifunc);



			*ptr[0] = USHRT_MAX;

			return -ESRCH;

		}



		*ptr[0] = xa_to_value(val);

		return 0;

	}



	if (is_vf(pcifunc)) {

		if (!ptr[3])

			return -EINVAL;



		idx = NPC_DFT_RULE_ID_MK(pcifunc, NPC_DFT_RULE_UCAST_ID);

		val = xa_load(&npc_priv.xa_pf2dfl_rmap, idx);

		if (!val) {

			pr_debug("%s: Failed to find %s index for pcifunc=%#x\n",

				 __func__,

				 npc_dft_rule_name[NPC_DFT_RULE_UCAST_ID],

				 pcifunc);



			*ptr[3] = USHRT_MAX;

			return -ESRCH;

		}



		*ptr[3] = xa_to_value(val);

		return 0;

	}



	for (i = NPC_DFT_RULE_START_ID, j = 0; i < NPC_DFT_RULE_MAX_ID; i++,

	     j++) {

		if (!ptr[j])

			continue;



		idx = NPC_DFT_RULE_ID_MK(pcifunc, i);

		val = xa_load(&npc_priv.xa_pf2dfl_rmap, idx);

		if (!val) {

			pr_debug("%s: Failed to find %s index for pcifunc=%#x\n",

				 __func__,

				 npc_dft_rule_name[i], pcifunc);



			*ptr[j] = USHRT_MAX;

			continue;

		}



		*ptr[j] = xa_to_value(val);

		set = true;

	}



	return  set ? 0 : -ESRCH;

}



static bool npc_is_cgx_or_lbk(struct rvu *rvu, u16 pcifunc)

{

	return is_pf_cgxmapped(rvu, rvu_get_pf(rvu->pdev, pcifunc)) ||

		is_lbk_vf(rvu, pcifunc);

}



void npc_cn20k_dft_rules_free(struct rvu *rvu, u16 pcifunc)

{

	struct npc_mcam_free_entry_req free_req = { 0 };

	unsigned long index;

	struct msg_rsp rsp;

	u16 ptr[4];

	int rc, i;

	void *map;



	if (!npc_priv.init_done)

		return;



	if (!npc_is_cgx_or_lbk(rvu, pcifunc)) {

		dev_dbg(rvu->dev,

			"%s: dft rule allocation is only for cgx mapped device, pcifunc=%#x\n",

			__func__, pcifunc);

		return;

	}



	rc = npc_cn20k_dft_rules_idx_get(rvu, pcifunc, &ptr[0], &ptr[1],

					 &ptr[2], &ptr[3]);

	if (rc)

		return;



	/* LBK */

	if (is_lbk_vf(rvu, pcifunc)) {

		index = NPC_DFT_RULE_ID_MK(pcifunc, NPC_DFT_RULE_PROMISC_ID);

		map = xa_erase(&npc_priv.xa_pf2dfl_rmap, index);

		if (!map)

			dev_dbg(rvu->dev,

				"%s: Err from delete %s mcam idx from xarray (pcifunc=%#x\n",

				__func__,

				npc_dft_rule_name[NPC_DFT_RULE_PROMISC_ID],

				pcifunc);



		goto free_rules;

	}



	/* VF */

	if (is_vf(pcifunc)) {

		index = NPC_DFT_RULE_ID_MK(pcifunc, NPC_DFT_RULE_UCAST_ID);

		map = xa_erase(&npc_priv.xa_pf2dfl_rmap, index);

		if (!map)

			dev_dbg(rvu->dev,

				"%s: Err from delete %s mcam idx from xarray (pcifunc=%#x\n",

				__func__,

				npc_dft_rule_name[NPC_DFT_RULE_UCAST_ID],

				pcifunc);



		goto free_rules;

	}



	/* PF */

	for (i = NPC_DFT_RULE_START_ID; i < NPC_DFT_RULE_MAX_ID; i++)  {

		index = NPC_DFT_RULE_ID_MK(pcifunc, i);

		map = xa_erase(&npc_priv.xa_pf2dfl_rmap, index);

		if (!map)

			dev_dbg(rvu->dev,

				"%s: Err from delete %s mcam idx from xarray (pcifunc=%#x\n",

				__func__, npc_dft_rule_name[i],

				pcifunc);

	}



free_rules:



	free_req.hdr.pcifunc = pcifunc;

	free_req.all = 1;

	rc = rvu_mbox_handler_npc_mcam_free_entry(rvu, &free_req, &rsp);

	if (rc)

		dev_err(rvu->dev,

			"%s: Error deleting default entries (pcifunc=%#x\n",

			__func__, pcifunc);

}



int npc_cn20k_dft_rules_alloc(struct rvu *rvu, u16 pcifunc)

{

	struct npc_mcam_free_entry_req free_req = { 0 };

	u16 mcam_idx[4] = { 0 }, pf_ucast, pf_pcifunc;

	struct npc_mcam_alloc_entry_req req = { 0 };

	struct npc_mcam_alloc_entry_rsp rsp = { 0 };

	int ret, eidx, i, k, pf, cnt;

	struct rvu_pfvf *pfvf;

	unsigned long index;

	struct msg_rsp free_rsp;

	u16 b, m, p, u;



	if (!npc_priv.init_done)

		return 0;



	if (!npc_is_cgx_or_lbk(rvu, pcifunc)) {

		dev_dbg(rvu->dev,

			"%s: dft rule allocation is only for cgx mapped device, pcifunc=%#x\n",

			__func__, pcifunc);

		return 0;

	}



	/* Check if default rules are already alloced for this pcifunc */

	ret =  npc_cn20k_dft_rules_idx_get(rvu, pcifunc, &b, &m, &p, &u);

	if (!ret) {

		dev_dbg(rvu->dev,

			"%s: default rules are already installed (pcifunc=%#x)\n",

			__func__, pcifunc);

		dev_dbg(rvu->dev,

			"%s: bcast(%u) mcast(%u) promisc(%u) ucast(%u)\n",

			__func__, b, m, p, u);

		return 0;

	}



	/* Set ref index as lowest priority index */

	eidx = 2 * npc_priv.bank_depth - 1;



	/* Install only UCAST for VF */

	cnt = is_vf(pcifunc) ? 1 : ARRAY_SIZE(mcam_idx);



	/* For VF pcifunc, allocate default mcam indexes by taking

	 * ref as PF's ucast index.

	 */

	if (is_vf(pcifunc)) {

		pf = rvu_get_pf(rvu->pdev, pcifunc);

		pf_pcifunc = pf << RVU_CN20K_PFVF_PF_SHIFT;



		/* Get PF's ucast entry index */

		ret = npc_cn20k_dft_rules_idx_get(rvu, pf_pcifunc, NULL,

						  NULL, NULL, &pf_ucast);



		/* There is no PF rules installed; and VF installation comes

		 * first. PF may come later.

		 * TODO: Install PF rules before installing VF rules.

		 */



		/* Set PF's ucast as ref entry */

		if (!ret)

			eidx = pf_ucast;

	}



	pfvf = rvu_get_pfvf(rvu, pcifunc);

	pfvf->hw_prio = NPC_DFT_RULE_PRIO;



	req.contig = false;

	req.ref_prio = NPC_MCAM_HIGHER_PRIO;

	req.ref_entry = eidx;

	req.kw_type = NPC_MCAM_KEY_X2;

	req.count = cnt;

	req.hdr.pcifunc = pcifunc;



	ret = rvu_mbox_handler_npc_mcam_alloc_entry(rvu, &req, &rsp);



	/* successfully allocated index */

	if (!ret) {

		/* Copy indexes to local array */

		for (i = 0; i < cnt; i++)

			mcam_idx[i] = rsp.entry_list[i];



		goto chk_sanity;

	}



	/* If there is no slots available and request is for PF,

	 * return error.

	 */

	if (!is_vf(pcifunc)) {

		dev_err(rvu->dev,

			"%s: Default index allocation failed for pcifunc=%#x\n",

			__func__, pcifunc);

		return ret;

	}



	/* We could not find an index with higher priority index for VF.

	 * Find rule with lower priority index and set hardware priority

	 * as NPC_DFT_RULE_PRIO - 1 (higher hw priority)

	 */

	req.contig = false;

	req.kw_type = NPC_MCAM_KEY_X2;

	req.count = cnt;

	req.hdr.pcifunc = pcifunc;

	req.ref_prio = NPC_MCAM_LOWER_PRIO;

	req.ref_entry = eidx + 1;

	ret = rvu_mbox_handler_npc_mcam_alloc_entry(rvu, &req, &rsp);

	if (ret) {

		dev_err(rvu->dev,

			"%s: Default index allocation failed for pcifunc=%#x\n",

			__func__, pcifunc);

		return ret;

	}



	/* Copy indexes to local array */

	for (i = 0; i < cnt; i++)

		mcam_idx[i] = rsp.entry_list[i];



	pfvf->hw_prio = NPC_DFT_RULE_PRIO - 1;



chk_sanity:

	/* LBK */

	if (is_lbk_vf(rvu, pcifunc)) {

		index = NPC_DFT_RULE_ID_MK(pcifunc, NPC_DFT_RULE_PROMISC_ID);

		ret = xa_insert(&npc_priv.xa_pf2dfl_rmap, index,

				xa_mk_value(mcam_idx[0]), GFP_KERNEL);

		if (ret) {

			dev_err(rvu->dev,

				"%s: Err to insert %s mcam idx to xarray pcifunc=%#x\n",

				__func__,

				npc_dft_rule_name[NPC_DFT_RULE_PROMISC_ID],

				pcifunc);

			goto err;

		}



		goto done;

	}



	/* VF */

	if (is_vf(pcifunc)) {

		index = NPC_DFT_RULE_ID_MK(pcifunc, NPC_DFT_RULE_UCAST_ID);

		ret = xa_insert(&npc_priv.xa_pf2dfl_rmap, index,

				xa_mk_value(mcam_idx[0]), GFP_KERNEL);

		if (ret) {

			dev_err(rvu->dev,

				"%s: Err to insert %s mcam idx to xarray pcifunc=%#x\n",

				__func__,

				npc_dft_rule_name[NPC_DFT_RULE_UCAST_ID],

				pcifunc);

			goto err;

		}



		goto done;

	}



	/* PF */

	for (i = NPC_DFT_RULE_START_ID, k = 0; i < NPC_DFT_RULE_MAX_ID &&

	     k < cnt; i++, k++) {

		index = NPC_DFT_RULE_ID_MK(pcifunc, i);

		ret = xa_insert(&npc_priv.xa_pf2dfl_rmap, index,

				xa_mk_value(mcam_idx[k]), GFP_KERNEL);

		if (ret) {

			dev_err(rvu->dev,

				"%s: Err to insert %s mcam idx to xarray pcifunc=%#x\n",

				__func__, npc_dft_rule_name[i],

				pcifunc);

			for (int p = NPC_DFT_RULE_START_ID; p < i; p++) {

				index = NPC_DFT_RULE_ID_MK(pcifunc, p);

				xa_erase(&npc_priv.xa_pf2dfl_rmap, index);

			}

			goto err;

		}

	}



done:

	return 0;



err:

	free_req.hdr.pcifunc = pcifunc;

	free_req.all = 1;

	ret = rvu_mbox_handler_npc_mcam_free_entry(rvu, &free_req, &free_rsp);

	if (ret)

		dev_err(rvu->dev,

			"%s: Error deleting default entries (pcifunc=%#x\n",

			__func__, pcifunc);



	return -EFAULT;

}



static int npc_priv_init(struct rvu *rvu)

{

	struct npc_mcam *mcam = &rvu->hw->mcam;
@@ -2442,6 +2800,7 @@ static int npc_priv_init(struct rvu *rvu) 
	xa_init_flags(&npc_priv.xa_sb_free, XA_FLAGS_ALLOC);

	xa_init_flags(&npc_priv.xa_idx2pf_map, XA_FLAGS_ALLOC);

	xa_init_flags(&npc_priv.xa_pf_map, XA_FLAGS_ALLOC);

	xa_init_flags(&npc_priv.xa_pf2dfl_rmap, XA_FLAGS_ALLOC);



	if (npc_create_srch_order(num_subbanks))

		goto fail1;
@@ -2474,6 +2833,7 @@ static int npc_priv_init(struct rvu *rvu) 
	xa_destroy(&npc_priv.xa_sb_free);

	xa_destroy(&npc_priv.xa_idx2pf_map);

	xa_destroy(&npc_priv.xa_pf_map);

	xa_destroy(&npc_priv.xa_pf2dfl_rmap);

	kfree(npc_priv.sb);

	npc_priv.sb = NULL;

	return -ENOMEM;
@@ -2487,6 +2847,7 @@ void npc_cn20k_deinit(struct rvu *rvu) 
	xa_destroy(&npc_priv.xa_sb_free);

	xa_destroy(&npc_priv.xa_idx2pf_map);

	xa_destroy(&npc_priv.xa_pf_map);

	xa_destroy(&npc_priv.xa_pf2dfl_rmap);



	for (i = 0; i < npc_priv.pf_cnt; i++)

		xa_destroy(&npc_priv.xa_pf2idx_map[i]);

drivers/net/ethernet/marvell/octeontx2/af/cn20k/npc.h

+29 −0
Original line number Diff line number Diff line
@@ -95,6 +95,27 @@ enum npc_subbank_flag { 
	NPC_SUBBANK_FLAG_USED = BIT(1),

};



/**

 * enum npc_dft_rule_id - Default rule type

 *

 * Mcam default rule type.

 *

 * @NPC_DFT_RULE_START_ID:	Not used

 * @NPC_DFT_RULE_PROMISC_ID:	promiscuous rule

 * @NPC_DFT_RULE_MCAST_ID:	multicast rule

 * @NPC_DFT_RULE_BCAST_ID:	broadcast rule

 * @NPC_DFT_RULE_UCAST_ID:	unicast rule

 * @NPC_DFT_RULE_MAX_ID:	Maximum index.

 */

enum npc_dft_rule_id {

	NPC_DFT_RULE_START_ID = 1,

	NPC_DFT_RULE_PROMISC_ID = NPC_DFT_RULE_START_ID,

	NPC_DFT_RULE_MCAST_ID,

	NPC_DFT_RULE_BCAST_ID,

	NPC_DFT_RULE_UCAST_ID,

	NPC_DFT_RULE_MAX_ID,

};



/**

 * struct npc_subbank - Subbank fields.

 * @b0b:	Subbanks bottom index for bank0
@@ -141,6 +162,7 @@ struct npc_subbank { 
 * @xa_pf_map:		Pcifunc to index map.

 * @pf_cnt:		Number of PFs.

 * @init_done:		Indicates MCAM initialization is done.

 * @xa_pf2dfl_rmap:	PF to default rule index map.

 *

 * This structure is populated during probing time by reading

 * HW csr registers.
@@ -157,6 +179,7 @@ struct npc_priv_t { 
	struct xarray *xa_pf2idx_map;

	struct xarray xa_idx2pf_map;

	struct xarray xa_pf_map;

	struct xarray xa_pf2dfl_rmap;

	int pf_cnt;

	bool init_done;

};
@@ -265,4 +288,10 @@ int npc_cn20k_apply_custom_kpu(struct rvu *rvu, 
void

npc_cn20k_update_action_entries_n_flags(struct rvu *rvu,

					struct npc_kpu_profile_adapter *pfl);



int npc_cn20k_dft_rules_alloc(struct rvu *rvu, u16 pcifunc);

void npc_cn20k_dft_rules_free(struct rvu *rvu, u16 pcifunc);



int npc_cn20k_dft_rules_idx_get(struct rvu *rvu, u16 pcifunc, u16 *bcast,

				u16 *mcast, u16 *promisc, u16 *ucast);

#endif /* NPC_CN20K_H */

drivers/net/ethernet/marvell/octeontx2/af/mbox.h

+6 −2
Original line number Diff line number Diff line
@@ -1539,9 +1539,10 @@ struct npc_mcam_alloc_entry_req { 
#define NPC_MCAM_ANY_PRIO		0

#define NPC_MCAM_LOWER_PRIO		1

#define NPC_MCAM_HIGHER_PRIO		2

	u8  priority; /* Lower or higher w.r.t ref_entry */

	u8  ref_prio; /* Lower or higher w.r.t ref_entry */

	u16 ref_entry;

	u16 count;    /* Number of entries requested */

	u8 kw_type; /* entry key type, valid for cn20k */

};



struct npc_mcam_alloc_entry_rsp {
@@ -1634,10 +1635,12 @@ struct npc_mcam_alloc_and_write_entry_req { 
	struct mbox_msghdr hdr;

	struct mcam_entry entry_data;

	u16 ref_entry;

	u8  priority;    /* Lower or higher w.r.t ref_entry */

	u8  ref_prio;    /* Lower or higher w.r.t ref_entry */

	u8  intf;	 /* Rx or Tx interface */

	u8  enable_entry;/* Enable this MCAM entry ? */

	u8  alloc_cntr;  /* Allocate counter and map ? */

	/* hardware priority, supported for cn20k */

	u8 hw_prio;

};



struct npc_mcam_alloc_and_write_entry_rsp {
@@ -1790,6 +1793,7 @@ struct npc_install_flow_req { 
	u8  vtag1_op;

	/* old counter value */

	u16 cntr_val;

	u8 hw_prio;

};



struct npc_install_flow_rsp {

drivers/net/ethernet/marvell/octeontx2/af/rvu.c

+25 −7
Original line number Diff line number Diff line
@@ -22,6 +22,7 @@ 
#include "rvu_npc_hash.h"

#include "cn20k/reg.h"

#include "cn20k/api.h"

#include "cn20k/npc.h"



#define DRV_NAME	"rvu_af"

#define DRV_STRING      "Marvell OcteonTX2 RVU Admin Function Driver"
@@ -1467,6 +1468,13 @@ static int rvu_detach_rsrcs(struct rvu *rvu, struct rsrc_detach *detach, 
			else if ((blkid == BLKADDR_CPT1) && !detach->cptlfs)

				continue;

		}



		if (detach_all ||

		    (detach && (blkid == BLKADDR_NIX0 ||

				blkid == BLKADDR_NIX1) &&

		     detach->nixlf))

			npc_cn20k_dft_rules_free(rvu, pcifunc);



		rvu_detach_block(rvu, pcifunc, block->type);

	}
@@ -1750,6 +1758,12 @@ int rvu_mbox_handler_attach_resources(struct rvu *rvu, 
		err = rvu_attach_block(rvu, pcifunc, BLKTYPE_NIX, 1, attach);

		if (err)

			goto fail2;



		if (is_cn20k(rvu->pdev)) {

			err = npc_cn20k_dft_rules_alloc(rvu, pcifunc);

			if (err)

				goto fail3;

		}

	}



	if (attach->sso) {
@@ -1763,7 +1777,7 @@ int rvu_mbox_handler_attach_resources(struct rvu *rvu, 
		err = rvu_attach_block(rvu, pcifunc, BLKTYPE_SSO,

				       attach->sso, attach);

		if (err)

			goto fail3;

			goto fail4;

	}



	if (attach->ssow) {
@@ -1772,7 +1786,7 @@ int rvu_mbox_handler_attach_resources(struct rvu *rvu, 
		err = rvu_attach_block(rvu, pcifunc, BLKTYPE_SSOW,

				       attach->ssow, attach);

		if (err)

			goto fail4;

			goto fail5;

	}



	if (attach->timlfs) {
@@ -1781,7 +1795,7 @@ int rvu_mbox_handler_attach_resources(struct rvu *rvu, 
		err = rvu_attach_block(rvu, pcifunc, BLKTYPE_TIM,

				       attach->timlfs, attach);

		if (err)

			goto fail5;

			goto fail6;

	}



	if (attach->cptlfs) {
@@ -1791,24 +1805,28 @@ int rvu_mbox_handler_attach_resources(struct rvu *rvu, 
		err = rvu_attach_block(rvu, pcifunc, BLKTYPE_CPT,

				       attach->cptlfs, attach);

		if (err)

			goto fail6;

			goto fail7;

	}



	mutex_unlock(&rvu->rsrc_lock);

	return 0;



fail6:

fail7:

	if (attach->timlfs)

		rvu_detach_block(rvu, pcifunc, BLKTYPE_TIM);



fail5:

fail6:

	if (attach->ssow)

		rvu_detach_block(rvu, pcifunc, BLKTYPE_SSOW);



fail4:

fail5:

	if (attach->sso)

		rvu_detach_block(rvu, pcifunc, BLKTYPE_SSO);



fail4:

	if (is_cn20k(rvu->pdev))

		npc_cn20k_dft_rules_free(rvu, pcifunc);



fail3:

	if (attach->nixlf)

		rvu_detach_block(rvu, pcifunc, BLKTYPE_NIX);

drivers/net/ethernet/marvell/octeontx2/af/rvu.h

+1 −0
Original line number Diff line number Diff line
@@ -308,6 +308,7 @@ struct rvu_pfvf { 
	u64     lmt_map_ent_w1; /* Preseving the word1 of lmtst map table entry*/

	unsigned long flags;

	struct  sdp_node_info *sdp_info;

	u8	hw_prio;   /* Hw priority of default rules */

};



enum rvu_pfvf_flags {