Commit 09e76365 authored by Jiawen Wu's avatar Jiawen Wu Committed by Jakub Kicinski
Browse files

net: libwx: Fix FW mailbox unknown command 



For the new SW-FW interaction, missing the error return if there is an
unknown command. It causes the driver to mistakenly believe that the
interaction is complete. This problem occurs when new driver is paired
with old firmware, which does not support the new mailbox commands.

Fixes: 2e5af6b2 ("net: txgbe: Add basic support for new AML devices")
Signed-off-by: default avatarJiawen Wu <jiawenwu@trustnetic.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/64DBB705D35A0016+20250513021009.145708-4-jiawenwu@trustnetic.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 42efa358

drivers/net/ethernet/wangxun/libwx/wx_hw.c

+6 −0
Original line number Diff line number Diff line
@@ -442,6 +442,12 @@ static int wx_host_interface_command_r(struct wx *wx, u32 *buffer, 
		goto rel_out;

	}



	if (hdr->cmd_or_resp.ret_status == 0x80) {

		wx_err(wx, "Unknown FW command: 0x%x\n", send_cmd);

		err = -EINVAL;

		goto rel_out;

	}



	/* expect no reply from FW then return */

	if (!return_data)

		goto rel_out;