Commit 09ed594e authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Greg Kroah-Hartman
Browse files

misc: hisi_hikey_usb: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarJohn Stultz <jstultz@google.com>
Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/8775e9573fec55c5fc04151800829e9aeafc5dda.1708508896.git.u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0f841590

drivers/misc/hisi_hikey_usb.c

+2 −4
Original line number Diff line number Diff line
@@ -238,7 +238,7 @@ static int hisi_hikey_usb_probe(struct platform_device *pdev) 
	return 0;

}



static int  hisi_hikey_usb_remove(struct platform_device *pdev)

static void hisi_hikey_usb_remove(struct platform_device *pdev)

{

	struct hisi_hikey_usb *hisi_hikey_usb = platform_get_drvdata(pdev);
@@ -250,8 +250,6 @@ static int hisi_hikey_usb_remove(struct platform_device *pdev) 
	} else {

		hub_power_ctrl(hisi_hikey_usb, HUB_VBUS_POWER_OFF);

	}



	return 0;

}



static const struct of_device_id id_table_hisi_hikey_usb[] = {
@@ -262,7 +260,7 @@ MODULE_DEVICE_TABLE(of, id_table_hisi_hikey_usb); 


static struct platform_driver hisi_hikey_usb_driver = {

	.probe = hisi_hikey_usb_probe,

	.remove = hisi_hikey_usb_remove,

	.remove_new = hisi_hikey_usb_remove,

	.driver = {

		.name = DEVICE_DRIVER_NAME,

		.of_match_table = id_table_hisi_hikey_usb,