Commit 0a1fc2f3 authored by Daniel Hodges's avatar Daniel Hodges Committed by Keith Busch
Browse files

nvme-fabrics: use kfree_sensitive() for DHCHAP secrets 



The DHCHAP secrets (dhchap_secret and dhchap_ctrl_secret) contain
authentication key material for NVMe-oF. Use kfree_sensitive() instead
of kfree() in nvmf_free_options() to ensure secrets are zeroed before
the memory is freed, preventing recovery from freed pages.

Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarDaniel Hodges <hodgesd@meta.com>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent ac30cd30

drivers/nvme/host/fabrics.c

+2 −2
Original line number Diff line number Diff line
@@ -1290,8 +1290,8 @@ void nvmf_free_options(struct nvmf_ctrl_options *opts) 
	kfree(opts->subsysnqn);

	kfree(opts->host_traddr);

	kfree(opts->host_iface);

	kfree(opts->dhchap_secret);

	kfree(opts->dhchap_ctrl_secret);

	kfree_sensitive(opts->dhchap_secret);

	kfree_sensitive(opts->dhchap_ctrl_secret);

	kfree(opts);

}

EXPORT_SYMBOL_GPL(nvmf_free_options);