Unverified Commit 0a36bad0 authored by Oleg Nesterov's avatar Oleg Nesterov Committed by Christian Brauner
Browse files

release_task: kill the no longer needed get/put_pid(thread_pid) 



After the commit 7903f907 ("pid: perform free_pid() calls outside
of tasklist_lock") __unhash_process() -> detach_pid() no longer calls
free_pid(), proc_flush_pid() can just use p->thread_pid without the
now pointless get_pid() + put_pid().

Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
Link: https://lore.kernel.org/20250411121857.GA10550@redhat.com


Reviewed-by: default avatarMateusz Guzik <mjguzik@gmail.com>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent a9d7de0f

kernel/exit.c

+3 −2
Original line number Diff line number Diff line
@@ -258,7 +258,8 @@ void release_task(struct task_struct *p) 
	pidfs_exit(p);

	cgroup_release(p);



	thread_pid = get_pid(p->thread_pid);

	/* Retrieve @thread_pid before __unhash_process() may set it to NULL. */

	thread_pid = task_pid(p);



	write_lock_irq(&tasklist_lock);

	ptrace_release_task(p);
@@ -287,8 +288,8 @@ void release_task(struct task_struct *p) 
	}



	write_unlock_irq(&tasklist_lock);

	/* @thread_pid can't go away until free_pids() below */

	proc_flush_pid(thread_pid);

	put_pid(thread_pid);

	add_device_randomness(&p->se.sum_exec_runtime,

			      sizeof(p->se.sum_exec_runtime));

	free_pids(post.pids);