Commit 0a3f9f7f authored by Chen Ni's avatar Chen Ni Committed by Jiri Kosina
Browse files

HID: nvidia-shield: Add missing check for input_ff_create_memless 



Add check for the return value of input_ff_create_memless() and return
the error if it fails in order to catch the error.

Fixes: 09308562 ("HID: nvidia-shield: Initial driver implementation with Thunderstrike support")
Signed-off-by: default avatarChen Ni <nichen@iscas.ac.cn>
Reviewed-by: default avatarRahul Rameshbabu <rrameshbabu@nvidia.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
parent 23604972

drivers/hid/hid-nvidia-shield.c

+3 −1
Original line number Diff line number Diff line
@@ -283,7 +283,9 @@ static struct input_dev *shield_haptics_create( 
		return haptics;



	input_set_capability(haptics, EV_FF, FF_RUMBLE);

	input_ff_create_memless(haptics, NULL, play_effect);

	ret = input_ff_create_memless(haptics, NULL, play_effect);

	if (ret)

		goto err;



	ret = input_register_device(haptics);

	if (ret)