Commit 0a454e95 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Ulf Hansson
Browse files

mmc: atmel-mci: Incapsulate used to be a platform data into host structure 



After platform data is gone, we always allocate memory for the slot
information. Incapsulate the array of the latter into the host structure,
so we allocate memory only once. This makes code simpler.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20240425170900.3767990-2-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 0b7b565d

drivers/mmc/host/atmel-mci.c

+24 −37
Original line number Diff line number Diff line
@@ -224,14 +224,6 @@ struct mci_slot_pdata { 
	bool			non_removable;

};



/**

 * struct mci_platform_data - board-specific MMC/SDcard configuration

 * @slot: Per-slot configuration data.

 */

struct mci_platform_data {

	struct mci_slot_pdata	slot[ATMCI_MAX_NR_SLOTS];

};



struct atmel_mci_caps {

	bool    has_dma_conf_reg;

	bool    has_pdc;
@@ -297,6 +289,7 @@ struct atmel_mci_dma { 
 * @mapbase: Physical address of the MMIO registers.

 * @mck: The peripheral bus clock hooked up to the MMC controller.

 * @dev: Device associated with the MMC controller.

 * @pdata: Per-slot configuration data.

 * @slot: Slots sharing this MMC controller.

 * @caps: MCI capabilities depending on MCI version.

 * @prepare_data: function to setup MCI before data transfer which
@@ -375,6 +368,7 @@ struct atmel_mci { 
	struct clk		*mck;

	struct device		*dev;



	struct mci_slot_pdata	pdata[ATMCI_MAX_NR_SLOTS];

	struct atmel_mci_slot	*slot[ATMCI_MAX_NR_SLOTS];



	struct atmel_mci_caps   caps;
@@ -630,11 +624,11 @@ static const struct of_device_id atmci_dt_ids[] = { 


MODULE_DEVICE_TABLE(of, atmci_dt_ids);



static struct mci_platform_data *atmci_of_init(struct device *dev)

static int atmci_of_init(struct atmel_mci *host)

{

	struct device *dev = host->dev;

	struct device_node *np = dev->of_node;

	struct device_node *cnp;

	struct mci_platform_data *pdata;

	u32 slot_id;

	int err;
@@ -643,10 +637,6 @@ static struct mci_platform_data *atmci_of_init(struct device *dev) 
		return ERR_PTR(-EINVAL);

	}



	pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);

	if (!pdata)

		return ERR_PTR(-ENOMEM);



	for_each_child_of_node(np, cnp) {

		if (of_property_read_u32(cnp, "reg", &slot_id)) {

			dev_warn(dev, "reg property is missing for %pOF\n", cnp);
@@ -661,38 +651,38 @@ static struct mci_platform_data *atmci_of_init(struct device *dev) 
		}



		if (of_property_read_u32(cnp, "bus-width",

		                         &pdata->slot[slot_id].bus_width))

			pdata->slot[slot_id].bus_width = 1;

					 &host->pdata[slot_id].bus_width))

			host->pdata[slot_id].bus_width = 1;



		pdata->slot[slot_id].detect_pin =

		host->pdata[slot_id].detect_pin =

			devm_fwnode_gpiod_get(dev, of_fwnode_handle(cnp),

					      "cd", GPIOD_IN, "cd-gpios");

		err = PTR_ERR_OR_ZERO(pdata->slot[slot_id].detect_pin);

		err = PTR_ERR_OR_ZERO(host->pdata[slot_id].detect_pin);

		if (err) {

			if (err != -ENOENT) {

				of_node_put(cnp);

				return ERR_PTR(err);

				return err;

			}

			pdata->slot[slot_id].detect_pin = NULL;

			host->pdata[slot_id].detect_pin = NULL;

		}



		pdata->slot[slot_id].non_removable =

		host->pdata[slot_id].non_removable =

			of_property_read_bool(cnp, "non-removable");



		pdata->slot[slot_id].wp_pin =

		host->pdata[slot_id].wp_pin =

			devm_fwnode_gpiod_get(dev, of_fwnode_handle(cnp),

					      "wp", GPIOD_IN, "wp-gpios");

		err = PTR_ERR_OR_ZERO(pdata->slot[slot_id].wp_pin);

		err = PTR_ERR_OR_ZERO(host->pdata[slot_id].wp_pin);

		if (err) {

			if (err != -ENOENT) {

				of_node_put(cnp);

				return ERR_PTR(err);

				return err;

			}

			pdata->slot[slot_id].wp_pin = NULL;

			host->pdata[slot_id].wp_pin = NULL;

		}

	}



	return pdata;

	return 0;

}



static inline unsigned int atmci_get_version(struct atmel_mci *host)
@@ -2456,7 +2446,6 @@ static void atmci_get_cap(struct atmel_mci *host) 
static int atmci_probe(struct platform_device *pdev)

{

	struct device			*dev = &pdev->dev;

	struct mci_platform_data	*pdata;

	struct atmel_mci		*host;

	struct resource			*regs;

	unsigned int			nr_slots;
@@ -2467,12 +2456,6 @@ static int atmci_probe(struct platform_device *pdev) 
	if (!regs)

		return -ENXIO;



	pdata = atmci_of_init(dev);

	if (IS_ERR(pdata)) {

		dev_err(dev, "platform data not available\n");

		return PTR_ERR(pdata);

	}



	irq = platform_get_irq(pdev, 0);

	if (irq < 0)

		return irq;
@@ -2485,6 +2468,10 @@ static int atmci_probe(struct platform_device *pdev) 
	spin_lock_init(&host->lock);

	INIT_LIST_HEAD(&host->queue);



	ret = atmci_of_init(host);

	if (ret)

		return dev_err_probe(dev, ret, "Slot information not available\n");



	host->mck = devm_clk_get(dev, "mci_clk");

	if (IS_ERR(host->mck))

		return PTR_ERR(host->mck);
@@ -2544,16 +2531,16 @@ static int atmci_probe(struct platform_device *pdev) 
	/* We need at least one slot to succeed */

	nr_slots = 0;

	ret = -ENODEV;

	if (pdata->slot[0].bus_width) {

		ret = atmci_init_slot(host, &pdata->slot[0],

	if (host->pdata[0].bus_width) {

		ret = atmci_init_slot(host, &host->pdata[0],

				0, ATMCI_SDCSEL_SLOT_A, ATMCI_SDIOIRQA);

		if (!ret) {

			nr_slots++;

			host->buf_size = host->slot[0]->mmc->max_req_size;

		}

	}

	if (pdata->slot[1].bus_width) {

		ret = atmci_init_slot(host, &pdata->slot[1],

	if (host->pdata[1].bus_width) {

		ret = atmci_init_slot(host, &host->pdata[1],

				1, ATMCI_SDCSEL_SLOT_B, ATMCI_SDIOIRQB);

		if (!ret) {

			nr_slots++;