Commit 0a4cfed7 authored by Andy Shevchenko's avatar Andy Shevchenko
Browse files

pinctrl: tangier: Move default strength assignment to a switch-case 



iWhen ->pin_config_set() is called from the GPIO library (assumed
GpioIo() ACPI resource), the argument can be 1, when, for example,
PullDefault is provided. In such case we supply sane default in
the driver. Move that default assingment to a switch-case, so
it will be consolidated in one place.

Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Reviewed-by: default avatarRaag Jadav <raag.jadav@intel.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 2b9282af

drivers/pinctrl/intel/pinctrl-tangier.c

+2 −8
Original line number Diff line number Diff line
@@ -368,14 +368,11 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin, 
		break;



	case PIN_CONFIG_BIAS_PULL_UP:

		/* Set default strength value in case none is given */

		if (arg == 1)

			arg = 20000;



		switch (arg) {

		case 50000:

			term = BUFCFG_PUPD_VAL_50K;

			break;

		case 1: /* Set default strength value in case none is given */

		case 20000:

			term = BUFCFG_PUPD_VAL_20K;

			break;
@@ -394,14 +391,11 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin, 
		break;



	case PIN_CONFIG_BIAS_PULL_DOWN:

		/* Set default strength value in case none is given */

		if (arg == 1)

			arg = 20000;



		switch (arg) {

		case 50000:

			term = BUFCFG_PUPD_VAL_50K;

			break;

		case 1: /* Set default strength value in case none is given */

		case 20000:

			term = BUFCFG_PUPD_VAL_20K;

			break;