Commit 0a53be8e authored by Javier Carrasco's avatar Javier Carrasco Committed by Bartosz Golaszewski
Browse files

gpio: dwapb: switch to device_for_each_child_node_scoped() 



Switch to device_for_each_child_node_scoped() to simplify the code by
removing the need for a  call to fwnode_handle_put() in the error path.

This also prevents possible memory leaks if new error paths are added
without the required call to fwnode_handle_put().

Signed-off-by: default avatarJavier Carrasco <javier.carrasco.cruz@gmail.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Acked-by: default avatarSerge Semin <fancer.lancer@gmail.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20240928-gpio_device_for_each_child_node_scoped-v1-1-c20eff315f4f@gmail.com


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent f53ab435

drivers/gpio/gpio-dwapb.c

+1 −3
Original line number Diff line number Diff line
@@ -571,7 +571,6 @@ static void dwapb_get_irq(struct device *dev, struct fwnode_handle *fwnode, 


static struct dwapb_platform_data *dwapb_gpio_get_pdata(struct device *dev)

{

	struct fwnode_handle *fwnode;

	struct dwapb_platform_data *pdata;

	struct dwapb_port_property *pp;

	int nports;
@@ -592,7 +591,7 @@ static struct dwapb_platform_data *dwapb_gpio_get_pdata(struct device *dev) 
	pdata->nports = nports;



	i = 0;

	device_for_each_child_node(dev, fwnode)  {

	device_for_each_child_node_scoped(dev, fwnode)  {

		pp = &pdata->properties[i++];

		pp->fwnode = fwnode;
@@ -600,7 +599,6 @@ static struct dwapb_platform_data *dwapb_gpio_get_pdata(struct device *dev) 
		    pp->idx >= DWAPB_MAX_PORTS) {

			dev_err(dev,

				"missing/invalid port index for port%d\n", i);

			fwnode_handle_put(fwnode);

			return ERR_PTR(-EINVAL);

		}