Unverified Commit 0a5fb3cc authored by Cezary Rojewski's avatar Cezary Rojewski Committed by Mark Brown
Browse files

ASoC: Intel: avs: Keep module refcount up when gathering traces 



To prevent rmmod and similar behave unexpectedly when invoked on
snd_soc_avs module while the AudioDSP firmware tracing is ongoing,
increase the module refcount until the tracing is stopped.

Signed-off-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
Signed-off-by: default avatarAmadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Link: https://lore.kernel.org/r/20230929112436.787058-5-amadeuszx.slawinski@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 28a21cb2

sound/soc/intel/avs/debugfs.c

+4 −0
Original line number Diff line number Diff line
@@ -236,6 +236,9 @@ static int strace_open(struct inode *inode, struct file *file) 
	struct avs_dev *adev = inode->i_private;

	int ret;



	if (!try_module_get(adev->dev->driver->owner))

		return -ENODEV;



	if (kfifo_initialized(&adev->trace_fifo))

		return -EBUSY;
@@ -270,6 +273,7 @@ static int strace_release(struct inode *inode, struct file *file) 


	spin_unlock_irqrestore(&adev->trace_lock, flags);



	module_put(adev->dev->driver->owner);

	return 0;

}