Commit 0a86cdcb authored Nov 15, 2021 by Julian Wiedmann Committed by Heiko Carstens Dec 06, 2021

s390/qdio: clean up access to queue in qdio_handle_activate_check()



qdio_handle_activate_check() re-uses a queue-specific handler to report
that the ACTIVATE ccw has been terminated. It uses either the first
input or output queue, so we can hard-code q->nr as 0. Also don't
access the q->irq_ptr parent pointer, we already have a pointer to
the qdio_irq.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Reviewed-by: Benjamin Block <bblock@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>

parent 718ce9e1

drivers/s390/cio/qdio_main.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -669,8 +669,8 @@ static void qdio_handle_activate_check(struct qdio_irq *irq_ptr,
		goto no_handler;
		}

		q->handler(q->irq_ptr->cdev, QDIO_ERROR_ACTIVATE,
		q->nr, q->first_to_check, 0, irq_ptr->int_parm);
		q->handler(irq_ptr->cdev, QDIO_ERROR_ACTIVATE, 0, q->first_to_check,
		0, irq_ptr->int_parm);
		no_handler:
		qdio_set_state(irq_ptr, QDIO_IRQ_STATE_STOPPED);
		/*