Commit 0a98b40b authored by Markus Elfring's avatar Markus Elfring Committed by Steve French
Browse files

smb: client: Return a status code only as a constant in cifs_spnego_key_instantiate() 



* Return a status code without storing it in an intermediate variable.

* Delete the local variable “ret” and the label “error”
  which became unnecessary with this refactoring.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Acked-by: default avatarEnzo Matsumiya <ematsumiya@suse.de>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 61da08ec

fs/smb/client/cifs_spnego.c

+3 −9
Original line number Diff line number Diff line
@@ -24,20 +24,14 @@ static const struct cred *spnego_cred; 
static int

cifs_spnego_key_instantiate(struct key *key, struct key_preparsed_payload *prep)

{

	char *payload;

	int ret;

	char *payload = kmemdup(prep->data, prep->datalen, GFP_KERNEL);



	ret = -ENOMEM;

	payload = kmemdup(prep->data, prep->datalen, GFP_KERNEL);

	if (!payload)

		goto error;

		return -ENOMEM;



	/* attach the data */

	key->payload.data[0] = payload;

	ret = 0;



error:

	return ret;

	return 0;

}



static void