Commit 0a9c56dd authored by Myeonghun Pak's avatar Myeonghun Pak Committed by Thomas Zimmermann
Browse files

drm/loongson: Use managed KMS polling 



lsdc_pci_probe() initializes KMS polling before setting up vblank support,
requesting the IRQ and registering the DRM device. If any of those later
steps fails, probe returns without finalizing polling. The driver also
never finalizes polling on regular removal.

Use drmm_kms_helper_poll_init() so polling is tied to the DRM device
lifetime and automatically finalized on probe failure and device removal.

This issue was identified during our ongoing static-analysis research while
reviewing kernel code.

Fixes: f39db26c ("drm: Add kms driver for loongson display controller")
Cc: stable@vger.kernel.org
Co-developed-by: default avatarIjae Kim <ae878000@gmail.com>
Signed-off-by: default avatarIjae Kim <ae878000@gmail.com>
Reviewed-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarJianmin Lv <lvjianmin@loongson.cn>
Reviewed-by: default avatarHuacai Chen <chenhuacai@loongson.cn>
Signed-off-by: default avatarMyeonghun Pak <mhun512@gmail.com>
Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://patch.msgid.link/20260513065706.23803-1-mhun512@gmail.com
parent 1d59f36e

drivers/gpu/drm/loongson/lsdc_drv.c

+1 −1
Original line number Diff line number Diff line
@@ -293,7 +293,7 @@ static int lsdc_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 


	vga_client_register(pdev, lsdc_vga_set_decode);



	drm_kms_helper_poll_init(ddev);

	drmm_kms_helper_poll_init(ddev);



	if (loongson_vblank) {

		ret = drm_vblank_init(ddev, descp->num_of_crtc);