Commit 0aa3ca95 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jakub Kicinski
Browse files

net: mvpp2: Don't re-use loop iterator 



This function has a nested loop.  The problem is that both the inside
and outside loop use the same variable as an iterator.  I found this
via static analysis so I'm not sure the impact.  It could be that it
loops forever or, more likely, the loop exits early.

Fixes: 3a616b92 ("net: mvpp2: Add TX flow control support for jumbo frames")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/eaa8f403-7779-4d81-973d-a9ecddc0bf6f@stanley.mountain


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent f558120c

drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c

+3 −3
Original line number Diff line number Diff line
@@ -953,13 +953,13 @@ static void mvpp2_bm_pool_update_fc(struct mvpp2_port *port, 
static void mvpp2_bm_pool_update_priv_fc(struct mvpp2 *priv, bool en)

{

	struct mvpp2_port *port;

	int i;

	int i, j;



	for (i = 0; i < priv->port_count; i++) {

		port = priv->port_list[i];

		if (port->priv->percpu_pools) {

			for (i = 0; i < port->nrxqs; i++)

				mvpp2_bm_pool_update_fc(port, &port->priv->bm_pools[i],

			for (j = 0; j < port->nrxqs; j++)

				mvpp2_bm_pool_update_fc(port, &port->priv->bm_pools[j],

							port->tx_fc & en);

		} else {

			mvpp2_bm_pool_update_fc(port, port->pool_long, port->tx_fc & en);