Commit 0aab5772 authored by Sascha Bischoff's avatar Sascha Bischoff Committed by Catalin Marinas
Browse files

arm64/sysreg: Fix checks for incomplete sysreg definitions 



The checks for incomplete sysreg definitions were checking if the
next_bit was greater than 0, which is incorrect and missed occasions
where bit 0 hasn't been defined for a sysreg. The reason is that
next_bit is -1 when all bits have been processed (LSB - 1).

Change the checks to use >= 0, instead. Also, set next_bit in Mapping
to -1 instead of 0 to match these new checks.

There are no changes to the generated sysreg definitons as part of
this change, and conveniently no definitions lack definitions for bit
0.

Signed-off-by: default avatarSascha Bischoff <sascha.bischoff@arm.com>
Reviewed-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
parent b0a3f0e8

arch/arm64/tools/gen-sysreg.awk

+3 −3
Original line number Diff line number Diff line
@@ -133,7 +133,7 @@ $1 == "SysregFields" && block_current() == "Root" { 


$1 == "EndSysregFields" && block_current() == "SysregFields" {

	expect_fields(1)

	if (next_bit > 0)

	if (next_bit >= 0)

		fatal("Unspecified bits in " reg)



	define(reg "_RES0", "(" res0 ")")
@@ -188,7 +188,7 @@ $1 == "Sysreg" && block_current() == "Root" { 


$1 == "EndSysreg" && block_current() == "Sysreg" {

	expect_fields(1)

	if (next_bit > 0)

	if (next_bit >= 0)

		fatal("Unspecified bits in " reg)



	if (res0 != null)
@@ -225,7 +225,7 @@ $1 == "EndSysreg" && block_current() == "Sysreg" { 
	print "/* For " reg " fields see " $2 " */"

	print ""



        next_bit = 0

	next_bit = -1

	res0 = null

	res1 = null

	unkn = null