Commit 0b11b1c5 authored by Jakub Kicinski's avatar Jakub Kicinski Committed by David S. Miller
Browse files

netdev: let netlink core handle -EMSGSIZE errors 



Previous change added -EMSGSIZE handling to af_netlink, we don't
have to hide these errors any longer.

Theoretically the error handling changes from:
 if (err == -EMSGSIZE)
to
 if (err == -EMSGSIZE && skb->len)

everywhere, but in practice it doesn't matter.
All messages fit into NLMSG_GOODSIZE, so overflow of an empty
skb cannot happen.

Reviewed-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Reviewed-by: default avatarIdo Schimmel <idosch@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b5a89915

net/core/netdev-genl.c

+3 −12
Original line number Diff line number Diff line
@@ -152,10 +152,7 @@ int netdev_nl_dev_get_dumpit(struct sk_buff *skb, struct netlink_callback *cb) 
	}

	rtnl_unlock();



	if (err != -EMSGSIZE)

	return err;



	return skb->len;

}



static int
@@ -287,10 +284,7 @@ int netdev_nl_napi_get_dumpit(struct sk_buff *skb, struct netlink_callback *cb) 
	}

	rtnl_unlock();



	if (err != -EMSGSIZE)

	return err;



	return skb->len;

}



static int
@@ -463,10 +457,7 @@ int netdev_nl_queue_get_dumpit(struct sk_buff *skb, struct netlink_callback *cb) 
	}

	rtnl_unlock();



	if (err != -EMSGSIZE)

	return err;



	return skb->len;

}



static int netdev_genl_netdevice_event(struct notifier_block *nb,

net/core/page_pool_user.c

+0 −2
Original line number Diff line number Diff line
@@ -102,8 +102,6 @@ netdev_nl_page_pool_get_dump(struct sk_buff *skb, struct netlink_callback *cb, 
	mutex_unlock(&page_pools_lock);

	rtnl_unlock();



	if (skb->len && err == -EMSGSIZE)

		return skb->len;

	return err;

}