Commit 0b2bc381 authored by Kai Huang's avatar Kai Huang Committed by Dave Hansen
Browse files

x86/virt/tdx: Initialize all TDMRs 



After the global KeyID has been configured on all packages, initialize
all TDMRs to make all TDX-usable memory regions that are passed to the
TDX module become usable.

This is the last step of initializing the TDX module.

Initializing TDMRs can be time consuming on large memory systems as it
involves initializing all metadata entries for all pages that can be
used by TDX guests.  Initializing different TDMRs can be parallelized.
For now to keep it simple, just initialize all TDMRs one by one.  It can
be enhanced in the future.

Signed-off-by: default avatarKai Huang <kai.huang@intel.com>
Signed-off-by: default avatarDave Hansen <dave.hansen@linux.intel.com>
Reviewed-by: default avatarIsaku Yamahata <isaku.yamahata@intel.com>
Reviewed-by: default avatarKirill A. Shutemov <kirill.shutemov@linux.intel.com>
Reviewed-by: default avatarYuan Yao <yuan.yao@intel.com>
Reviewed-by: default avatarDave Hansen <dave.hansen@linux.intel.com>
Link: https://lore.kernel.org/all/20231208170740.53979-15-dave.hansen%40intel.com
parent e56d28df

arch/x86/virt/vmx/tdx/tdx.c

+52 −9
Original line number Diff line number Diff line
@@ -1034,6 +1034,56 @@ static int config_global_keyid(void) 
	return ret;

}



static int init_tdmr(struct tdmr_info *tdmr)

{

	u64 next;



	/*

	 * Initializing a TDMR can be time consuming.  To avoid long

	 * SEAMCALLs, the TDX module may only initialize a part of the

	 * TDMR in each call.

	 */

	do {

		struct tdx_module_args args = {

			.rcx = tdmr->base,

		};

		int ret;



		ret = seamcall_prerr_ret(TDH_SYS_TDMR_INIT, &args);

		if (ret)

			return ret;

		/*

		 * RDX contains 'next-to-initialize' address if

		 * TDH.SYS.TDMR.INIT did not fully complete and

		 * should be retried.

		 */

		next = args.rdx;

		cond_resched();

		/* Keep making SEAMCALLs until the TDMR is done */

	} while (next < tdmr->base + tdmr->size);



	return 0;

}



static int init_tdmrs(struct tdmr_info_list *tdmr_list)

{

	int i;



	/*

	 * This operation is costly.  It can be parallelized,

	 * but keep it simple for now.

	 */

	for (i = 0; i < tdmr_list->nr_consumed_tdmrs; i++) {

		int ret;



		ret = init_tdmr(tdmr_entry(tdmr_list, i));

		if (ret)

			return ret;

	}



	return 0;

}



static int init_tdx_module(void)

{

	struct tdx_tdmr_sysinfo tdmr_sysinfo;
@@ -1079,15 +1129,8 @@ static int init_tdx_module(void) 
	if (ret)

		goto err_reset_pamts;



	/*

	 * TODO:

	 *

	 *  - Configure the global KeyID on all packages.

	 *  - Initialize all TDMRs.

	 *

	 *  Return error before all steps are done.

	 */

	ret = -EINVAL;

	/* Initialize TDMRs to complete the TDX module initialization */

	ret = init_tdmrs(&tdx_tdmr_list);

	if (ret)

		goto err_reset_pamts;

arch/x86/virt/vmx/tdx/tdx.h

+1 −0
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ 
#define TDH_SYS_INIT		33

#define TDH_SYS_RD		34

#define TDH_SYS_LP_INIT		35

#define TDH_SYS_TDMR_INIT	36

#define TDH_SYS_CONFIG		45



/*