Commit 0b305b7c authored by Dan Carpenter's avatar Dan Carpenter Committed by Rob Clark
Browse files

drm/msm/gem: Fix error code msm_parse_deps() 



The SUBMIT_ERROR() macro turns the error code negative.  This extra '-'
operation turns it back to positive EINVAL again.  The error code is
passed to ERR_PTR() and since positive values are not an IS_ERR() it
eventually will lead to an oops.  Delete the '-'.

Fixes: 866e43b9 ("drm/msm: UAPI error reporting")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/637625/


Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
parent d7a5ac67

drivers/gpu/drm/msm/msm_gem_submit.c

+1 −1
Original line number Diff line number Diff line
@@ -509,7 +509,7 @@ static struct drm_syncobj **msm_parse_deps(struct msm_gem_submit *submit, 
		}



		if (syncobj_desc.flags & ~MSM_SUBMIT_SYNCOBJ_FLAGS) {

			ret = -SUBMIT_ERROR(EINVAL, submit, "invalid syncobj flags: %x", syncobj_desc.flags);

			ret = SUBMIT_ERROR(EINVAL, submit, "invalid syncobj flags: %x", syncobj_desc.flags);

			break;

		}