Commit 0bcac7b1 authored by Aleksei Oladko's avatar Aleksei Oladko Committed by Jakub Kicinski
Browse files

selftests: net: make ovs-dpctl.py fail when pyroute2 is unsupported 



The pmtu.sh kselftest configures OVS using ovs-dpctl.py and falls back
to ovs-vsctl only when ovs-dpctl.py fails. However, ovs-dpctl.py exits
with a success status when the installed pyroute2 package version is
lower than 0.6, even though the OVS datapath is not configured.

As a result, pmtu.sh assumes that the setup was successful and
continues running the test, which later fails due to the missing
OVS configuration.

Fix the exit code handling in ovs-dpctl.py so that pmtu.sh can detect
that the setup did not complete successfully and fall back to
ovs-vsctl.

Signed-off-by: default avatarAleksei Oladko <aleksey.oladko@virtuozzo.com>
Reviewed-by: default avatarAaron Conole <aconole@redhat.com>
Link: https://patch.msgid.link/20260306000127.519064-3-aleksey.oladko@virtuozzo.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent f4ac0cc8

tools/testing/selftests/net/openvswitch/ovs-dpctl.py

+1 −1
Original line number Diff line number Diff line
@@ -2583,7 +2583,7 @@ def main(argv): 
    prverscheck = pyroute2.__version__.split(".")

    if int(prverscheck[0]) == 0 and int(prverscheck[1]) < 6:

        print("Need to upgrade the python pyroute2 package to >= 0.6.")

        sys.exit(0)

        sys.exit(1)



    parser = argparse.ArgumentParser()

    parser.add_argument(