Commit 0bcbbf23 authored by Dmitry Torokhov's avatar Dmitry Torokhov
Browse files

Input: adp5588-keys - do not explicitly set device as wakeup source 



I2C core will set up device as a wakeup source and will configure interrupt
as a wakeup interrupt if client is created with I2C_CLIENT_WAKE flag. Let's
rely on this facility and to not unconditionally set up the device as
wakeup device in the driver.

Acked-by: default avatarMichael Hennerich <michael.hennerich@analog.com>
Link: https://lore.kernel.org/r/20220528045631.289821-4-dmitry.torokhov@gmail.com


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 45608827

drivers/input/keyboard/adp5588-keys.c

+0 −8
Original line number Diff line number Diff line
@@ -588,8 +588,6 @@ static int adp5588_probe(struct i2c_client *client, 
	if (error)

		return error;



	device_init_wakeup(&client->dev, 1);



	dev_info(&client->dev, "Rev.%d keypad, irq %d\n", revid, client->irq);

	return 0;

}
@@ -608,9 +606,6 @@ static int __maybe_unused adp5588_suspend(struct device *dev) 


	disable_irq(client->irq);



	if (device_may_wakeup(&client->dev))

		enable_irq_wake(client->irq);



	return 0;

}
@@ -618,9 +613,6 @@ static int __maybe_unused adp5588_resume(struct device *dev) 
{

	struct i2c_client *client = to_i2c_client(dev);



	if (device_may_wakeup(&client->dev))

		disable_irq_wake(client->irq);



	enable_irq(client->irq);



	return 0;