Commit 0bcd5b3b authored by Carolina Jubran's avatar Carolina Jubran Committed by Paolo Abeni
Browse files

net/mlx5e: Fix missing error assignment in mlx5e_xfrm_add_state() 



Assign the return value of mlx5_eswitch_block_mode() to 'err' before
checking it to avoid returning an uninitialized error code.

Fixes: 22239eb2 ("net/mlx5e: Prevent tunnel reformat when tunnel mode not allowed")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202510271649.uwsIxD6O-lkp@intel.com/
Closes: http://lore.kernel.org/linux-rdma/aPIEK4rLB586FdDt@stanley.mountain/


Signed-off-by: default avatarCarolina Jubran <cjubran@nvidia.com>
Reviewed-by: default avatarJianbo Liu <jianbol@nvidia.com>
Signed-off-by: default avatarTariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/1762681073-1084058-2-git-send-email-tariqt@nvidia.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 02e9578c

drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c

+2 −1
Original line number Diff line number Diff line
@@ -804,7 +804,8 @@ static int mlx5e_xfrm_add_state(struct net_device *dev, 
		goto err_xfrm;

	}



	if (mlx5_eswitch_block_mode(priv->mdev))

	err = mlx5_eswitch_block_mode(priv->mdev);

	if (err)

		goto unblock_ipsec;



	if (x->props.mode == XFRM_MODE_TUNNEL &&