Commit 0beca868 authored by Alex Hung's avatar Alex Hung Committed by Alex Deucher
Browse files

drm/amd/display: Check link_res->hpo_dp_link_enc before using it 



[WHAT & HOW]
Functions dp_enable_link_phy and dp_disable_link_phy can pass link_res
without initializing hpo_dp_link_enc and it is necessary to check for
null before dereferencing.

This fixes 2 FORWARD_NULL issues reported by Coverity.

Reviewed-by: default avatarRodrigo Siqueira <rodrigo.siqueira@amd.com>
Signed-off-by: default avatarJerry Zuo <jerry.zuo@amd.com>
Signed-off-by: default avatarAlex Hung <alex.hung@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 9932ca4c

drivers/gpu/drm/amd/display/dc/link/hwss/link_hwss_hpo_dp.c

+7 −0
Original line number Diff line number Diff line
@@ -28,6 +28,8 @@ 
#include "dccg.h"

#include "clk_mgr.h"



#define DC_LOGGER link->ctx->logger



void set_hpo_dp_throttled_vcp_size(struct pipe_ctx *pipe_ctx,

		struct fixed31_32 throttled_vcp_size)

{
@@ -124,6 +126,11 @@ void disable_hpo_dp_link_output(struct dc_link *link, 
		const struct link_resource *link_res,

		enum signal_type signal)

{

	if (!link_res->hpo_dp_link_enc) {

		DC_LOG_ERROR("%s: invalid hpo_dp_link_enc\n", __func__);

		return;

	}



		link_res->hpo_dp_link_enc->funcs->link_disable(link_res->hpo_dp_link_enc);

		link_res->hpo_dp_link_enc->funcs->disable_link_phy(

				link_res->hpo_dp_link_enc, signal);