Commit 0bee15a5 authored by Marc Kleine-Budde's avatar Marc Kleine-Budde
Browse files

can: esd: acc_start_xmit(): use can_dev_dropped_skb() instead of can_dropped_invalid_skb() 



In addition to can_dropped_invalid_skb(), the helper function
can_dev_dropped_skb() checks whether the device is in listen-only mode and
discards the skb accordingly.

Replace can_dropped_invalid_skb() by can_dev_dropped_skb() to also drop
skbs in for listen-only mode.

Reported-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
Closes: https://lore.kernel.org/all/20251017-bizarre-enchanted-quokka-f3c704-mkl@pengutronix.de/
Fixes: 9721866f ("can: esd: add support for esd GmbH PCIe/402 CAN interface family")
Link: https://patch.msgid.link/20251017-fix-skb-drop-check-v1-2-556665793fa4@pengutronix.de


Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 3a20c444

drivers/net/can/esd/esdacc.c

+1 −1
Original line number Diff line number Diff line
@@ -254,7 +254,7 @@ netdev_tx_t acc_start_xmit(struct sk_buff *skb, struct net_device *netdev) 
	u32 acc_id;

	u32 acc_dlc;



	if (can_dropped_invalid_skb(netdev, skb))

	if (can_dev_dropped_skb(netdev, skb))

		return NETDEV_TX_OK;



	/* Access core->tx_fifo_tail only once because it may be changed