Unverified Commit 0c02cacf authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Mark Brown
Browse files

ASoC: codecs: lpass-rx-macro: Keep static regmap_config as const 



The driver has static 'struct regmap_config', which is then customized
depending on device version.  This works fine, because there should not
be two devices in a system simultaneously and even less likely that such
two devices would have different versions, thus different regmap config.
However code is cleaner and more obvious when static data in the driver
is also const - it serves as a template.

Mark the 'struct regmap_config' as const and duplicate it in the probe()
with kmemdup to allow customizing per detected device variant.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://patch.msgid.link/20240701-b4-qcom-audio-lpass-codec-cleanups-v3-3-6d98d4dd1ef5@linaro.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent ee5e13b2

sound/soc/codecs/lpass-rx-macro.c

+10 −4
Original line number Diff line number Diff line
@@ -1663,7 +1663,7 @@ static bool rx_is_readable_register(struct device *dev, unsigned int reg) 
	return rx_is_rw_register(dev, reg);

}



static struct regmap_config rx_regmap_config = {

static const struct regmap_config rx_regmap_config = {

	.name = "rx_macro",

	.reg_bits = 16,

	.val_bits = 32, /* 8 but with 32 bit read/write */
@@ -3847,10 +3847,16 @@ static int rx_macro_probe(struct platform_device *pdev) 
		return -EINVAL;

	}



	rx_regmap_config.reg_defaults = reg_defaults;

	rx_regmap_config.num_reg_defaults = def_count;

	struct regmap_config *reg_config __free(kfree) = kmemdup(&rx_regmap_config,

								 sizeof(*reg_config),

								 GFP_KERNEL);

	if (!reg_config)

		return -ENOMEM;



	reg_config->reg_defaults = reg_defaults;

	reg_config->num_reg_defaults = def_count;



	rx->regmap = devm_regmap_init_mmio(dev, base, &rx_regmap_config);

	rx->regmap = devm_regmap_init_mmio(dev, base, reg_config);

	if (IS_ERR(rx->regmap))

		return PTR_ERR(rx->regmap);