Commit 0c150b30 authored by John Garry's avatar John Garry Committed by Martin K. Petersen
Browse files

scsi: sd: Don't check if a write for REQ_ATOMIC 



Flag REQ_ATOMIC can only be set for writes, so don't check if the operation
is also a write in sd_setup_read_write_cmnd().

Fixes: bf4ae8f2 ("scsi: sd: Atomic write support")
Signed-off-by: default avatarJohn Garry <john.g.garry@oracle.com>
Link: https://lore.kernel.org/r/20240805113315.1048591-2-john.g.garry@oracle.com


Reviewed-by: default avatarKanchan Joshi <joshi.k@samsung.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 5f36bd89

drivers/scsi/sd.c

+1 −1
Original line number Diff line number Diff line
@@ -1382,7 +1382,7 @@ static blk_status_t sd_setup_read_write_cmnd(struct scsi_cmnd *cmd) 
	if (protect && sdkp->protection_type == T10_PI_TYPE2_PROTECTION) {

		ret = sd_setup_rw32_cmnd(cmd, write, lba, nr_blocks,

					 protect | fua, dld);

	} else if (rq->cmd_flags & REQ_ATOMIC && write) {

	} else if (rq->cmd_flags & REQ_ATOMIC) {

		ret = sd_setup_atomic_cmnd(cmd, lba, nr_blocks,

				sdkp->use_atomic_write_boundary,

				protect | fua);