Commit 0c21a18d authored by Sunil V L's avatar Sunil V L Committed by Rafael J. Wysocki
Browse files

ACPI: irq: Fix incorrect return value in acpi_register_gsi() 



acpi_register_gsi() should return a negative value in case of failure.

Currently, it returns the return value from irq_create_fwspec_mapping().
However, irq_create_fwspec_mapping() returns 0 for failure. Fix the
issue by returning -EINVAL if irq_create_fwspec_mapping() returns zero.

Fixes: d44fa3d4 ("ACPI: Add support for ResourceSource/IRQ domain mapping")
Cc: 4.11+ <stable@vger.kernel.org> # 4.11+
Signed-off-by: default avatarSunil V L <sunilvl@ventanamicro.com>
[ rjw: Rename a new local variable ]
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 58720809

drivers/acpi/irq.c

+6 −1
Original line number Diff line number Diff line
@@ -57,6 +57,7 @@ int acpi_register_gsi(struct device *dev, u32 gsi, int trigger, 
		      int polarity)

{

	struct irq_fwspec fwspec;

	unsigned int irq;



	fwspec.fwnode = acpi_get_gsi_domain_id(gsi);

	if (WARN_ON(!fwspec.fwnode)) {
@@ -68,7 +69,11 @@ int acpi_register_gsi(struct device *dev, u32 gsi, int trigger, 
	fwspec.param[1] = acpi_dev_get_irq_type(trigger, polarity);

	fwspec.param_count = 2;



	return irq_create_fwspec_mapping(&fwspec);

	irq = irq_create_fwspec_mapping(&fwspec);

	if (!irq)

		return -EINVAL;



	return irq;

}

EXPORT_SYMBOL_GPL(acpi_register_gsi);