Commit 0c345792 authored by Robin Murphy's avatar Robin Murphy Committed by Joerg Roedel
Browse files

OF: Retire dma-ranges mask workaround 



The fixup adding 1 to the dma-ranges size may have been for the benefit
of some early AMD Seattle DTs, or may have merely been a just-in-case,
but either way anyone who might have deserved to get the message has
hopefully seen the warning in the 9 years we've had it there. The modern
dma_range_map mechanism should happily handle odd-sized ranges with no
ill effect, so there's little need to care anyway now. Clean it up.

Acked-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarRobin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/26620039901fdae52079ec1c8a4b2b324964a13e.1713523152.git.robin.murphy@arm.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent d2f85a26

drivers/of/device.c

+0 −16
Original line number Diff line number Diff line
@@ -129,22 +129,6 @@ int of_dma_configure_id(struct device *dev, struct device_node *np, 
				dma_end = r->dma_start + r->size;

		}

		size = dma_end - dma_start;



		/*

		 * Add a work around to treat the size as mask + 1 in case

		 * it is defined in DT as a mask.

		 */

		if (size & 1) {

			dev_warn(dev, "Invalid size 0x%llx for dma-range(s)\n",

				 size);

			size = size + 1;

		}



		if (!size) {

			dev_err(dev, "Adjusted size 0x%llx invalid\n", size);

			kfree(map);

			return -EINVAL;

		}

	}



	/*