Commit 0c542a69 authored by Caleb Sander Mateos's avatar Caleb Sander Mateos Committed by Jens Axboe
Browse files

io_uring/uring_cmd: specify io_uring_cmd_import_fixed() pointer type 



io_uring_cmd_import_fixed() takes a struct io_uring_cmd *, but the type
of the ioucmd parameter is void *. Make the pointer type explicit so the
compiler can type check it.

Signed-off-by: default avatarCaleb Sander Mateos <csander@purestorage.com>
Link: https://lore.kernel.org/r/20250228221514.604350-1-csander@purestorage.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 2fced376

include/linux/io_uring/cmd.h

+6 −4
Original line number Diff line number Diff line
@@ -40,7 +40,8 @@ static inline void io_uring_cmd_private_sz_check(size_t cmd_sz) 


#if defined(CONFIG_IO_URING)

int io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, int rw,

			      struct iov_iter *iter, void *ioucmd,

			      struct iov_iter *iter,

			      struct io_uring_cmd *ioucmd,

			      unsigned int issue_flags);



/*
@@ -68,8 +69,9 @@ void io_uring_cmd_mark_cancelable(struct io_uring_cmd *cmd, 
void io_uring_cmd_issue_blocking(struct io_uring_cmd *ioucmd);



#else

static inline int io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, int rw,

			      struct iov_iter *iter, void *ioucmd,

static inline int

io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, int rw,

			  struct iov_iter *iter, struct io_uring_cmd *ioucmd,

			  unsigned int issue_flags)

{

	return -EOPNOTSUPP;

io_uring/uring_cmd.c

+2 −1
Original line number Diff line number Diff line
@@ -245,7 +245,8 @@ int io_uring_cmd(struct io_kiocb *req, unsigned int issue_flags) 
}



int io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, int rw,

			      struct iov_iter *iter, void *ioucmd,

			      struct iov_iter *iter,

			      struct io_uring_cmd *ioucmd,

			      unsigned int issue_flags)

{

	struct io_kiocb *req = cmd_to_io_kiocb(ioucmd);