Commit 0c56693b authored by Zilin Guan's avatar Zilin Guan Committed by Steve French
Browse files

ksmbd: Fix memory leak in get_file_all_info() 



In get_file_all_info(), if vfs_getattr() fails, the function returns
immediately without freeing the allocated filename, leading to a memory
leak.

Fix this by freeing the filename before returning in this error case.

Fixes: 5614c8c4 ("ksmbd: replace generic_fillattr with vfs_getattr")
Signed-off-by: default avatarZilin Guan <zilin@seu.edu.cn>
Acked-by: default avatarNamjae Jeon <linkinjeon@kernel.org>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent f8f9c1f4

fs/smb/server/smb2pdu.c

+3 −1
Original line number Diff line number Diff line
@@ -4923,8 +4923,10 @@ static int get_file_all_info(struct ksmbd_work *work, 


	ret = vfs_getattr(&fp->filp->f_path, &stat, STATX_BASIC_STATS,

			  AT_STATX_SYNC_AS_STAT);

	if (ret)

	if (ret) {

		kfree(filename);

		return ret;

	}



	ksmbd_debug(SMB, "filename = %s\n", filename);

	delete_pending = ksmbd_inode_pending_delete(fp);