Commit 0c5a89ce authored by Felix Fietkau's avatar Felix Fietkau
Browse files

wifi: mt76: only mark tx-status-failed frames as ACKed on mt76x0/2 

The interrupt status polling is unreliable, which can cause status events
to get lost. On all newer chips, txs-timeout is an indication that the
packet was either never sent, or never acked.
Fixes issues with inactivity polling.

Link: https://patch.msgid.link/20250311103646.43346-6-nbd@nbd.name


Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent 13b4c810

drivers/net/wireless/mediatek/mt76/mt76.h

+1 −0
Original line number Diff line number Diff line
@@ -492,6 +492,7 @@ struct mt76_hw_cap { 
#define MT_DRV_RX_DMA_HDR		BIT(3)

#define MT_DRV_HW_MGMT_TXQ		BIT(4)

#define MT_DRV_AMSDU_OFFLOAD		BIT(5)

#define MT_DRV_IGNORE_TXS_FAILED	BIT(6)



struct mt76_driver_ops {

	u32 drv_flags;

drivers/net/wireless/mediatek/mt76/mt76x0/pci.c

+2 −1
Original line number Diff line number Diff line
@@ -156,7 +156,8 @@ mt76x0e_probe(struct pci_dev *pdev, const struct pci_device_id *id) 
	static const struct mt76_driver_ops drv_ops = {

		.txwi_size = sizeof(struct mt76x02_txwi),

		.drv_flags = MT_DRV_TX_ALIGNED4_SKBS |

			     MT_DRV_SW_RX_AIRTIME,

			     MT_DRV_SW_RX_AIRTIME |

			     MT_DRV_IGNORE_TXS_FAILED,

		.survey_flags = SURVEY_INFO_TIME_TX,

		.update_survey = mt76x02_update_channel,

		.set_channel = mt76x0_set_channel,

drivers/net/wireless/mediatek/mt76/mt76x0/usb.c

+2 −1
Original line number Diff line number Diff line
@@ -214,7 +214,8 @@ static int mt76x0u_probe(struct usb_interface *usb_intf, 
			 const struct usb_device_id *id)

{

	static const struct mt76_driver_ops drv_ops = {

		.drv_flags = MT_DRV_SW_RX_AIRTIME,

		.drv_flags = MT_DRV_SW_RX_AIRTIME |

			     MT_DRV_IGNORE_TXS_FAILED,

		.survey_flags = SURVEY_INFO_TIME_TX,

		.update_survey = mt76x02_update_channel,

		.set_channel = mt76x0_set_channel,

drivers/net/wireless/mediatek/mt76/mt76x2/pci.c

+2 −1
Original line number Diff line number Diff line
@@ -22,7 +22,8 @@ mt76x2e_probe(struct pci_dev *pdev, const struct pci_device_id *id) 
	static const struct mt76_driver_ops drv_ops = {

		.txwi_size = sizeof(struct mt76x02_txwi),

		.drv_flags = MT_DRV_TX_ALIGNED4_SKBS |

			     MT_DRV_SW_RX_AIRTIME,

			     MT_DRV_SW_RX_AIRTIME |

			     MT_DRV_IGNORE_TXS_FAILED,

		.survey_flags = SURVEY_INFO_TIME_TX,

		.update_survey = mt76x02_update_channel,

		.set_channel = mt76x2e_set_channel,

drivers/net/wireless/mediatek/mt76/mt76x2/usb.c

+2 −1
Original line number Diff line number Diff line
@@ -29,7 +29,8 @@ static int mt76x2u_probe(struct usb_interface *intf, 
			 const struct usb_device_id *id)

{

	static const struct mt76_driver_ops drv_ops = {

		.drv_flags = MT_DRV_SW_RX_AIRTIME,

		.drv_flags = MT_DRV_SW_RX_AIRTIME |

			     MT_DRV_IGNORE_TXS_FAILED,

		.survey_flags = SURVEY_INFO_TIME_TX,

		.update_survey = mt76x02_update_channel,

		.set_channel = mt76x2u_set_channel,