Commit 0c82fd96 authored by Thorsten Blum's avatar Thorsten Blum Committed by Greg Kroah-Hartman
Browse files

ibmasm: Replace kzalloc() + copy_from_user() with memdup_user_nul() 



Replace kzalloc() followed by copy_from_user() with memdup_user_nul() to
improve and simplify remote_settings_file_write().

No functional changes intended.

Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Link: https://lore.kernel.org/r/20250905103247.423840-2-thorsten.blum@linux.dev


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5f8f84e2

drivers/misc/ibmasm/ibmasmfs.c

+3 −9
Original line number Diff line number Diff line
@@ -525,15 +525,9 @@ static ssize_t remote_settings_file_write(struct file *file, const char __user * 
	if (*offset != 0)

		return 0;



	buff = kzalloc (count + 1, GFP_KERNEL);

	if (!buff)

		return -ENOMEM;





	if (copy_from_user(buff, ubuff, count)) {

		kfree(buff);

		return -EFAULT;

	}

	buff = memdup_user_nul(ubuff, count);

	if (IS_ERR(buff))

		return PTR_ERR(buff);



	value = simple_strtoul(buff, NULL, 10);

	writel(value, address);