Unverified Commit 0c95c025 authored by Christian Brauner's avatar Christian Brauner Committed by Christian Brauner (Microsoft)
Browse files

fs: drop unused posix acl handlers 



Remove struct posix_acl_{access,default}_handler for all filesystems
that don't depend on the xattr handler in their inode->i_op->listxattr()
method in any way. There's nothing more to do than to simply remove the
handler. It's been effectively unused ever since we introduced the new
posix acl api.

Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarChristian Brauner (Microsoft) <brauner@kernel.org>
parent 831be973

fs/9p/xattr.c

+0 −4
Original line number Diff line number Diff line
@@ -183,10 +183,6 @@ static struct xattr_handler v9fs_xattr_security_handler = { 
const struct xattr_handler *v9fs_xattr_handlers[] = {

	&v9fs_xattr_user_handler,

	&v9fs_xattr_trusted_handler,

#ifdef CONFIG_FS_POSIX_ACL

	&posix_acl_access_xattr_handler,

	&posix_acl_default_xattr_handler,

#endif

#ifdef CONFIG_9P_FS_SECURITY

	&v9fs_xattr_security_handler,

#endif

fs/btrfs/xattr.c

+0 −4
Original line number Diff line number Diff line
@@ -444,10 +444,6 @@ static const struct xattr_handler btrfs_btrfs_xattr_handler = { 


const struct xattr_handler *btrfs_xattr_handlers[] = {

	&btrfs_security_xattr_handler,

#ifdef CONFIG_BTRFS_FS_POSIX_ACL

	&posix_acl_access_xattr_handler,

	&posix_acl_default_xattr_handler,

#endif

	&btrfs_trusted_xattr_handler,

	&btrfs_user_xattr_handler,

	&btrfs_btrfs_xattr_handler,

fs/ceph/xattr.c

+0 −4
Original line number Diff line number Diff line
@@ -1411,10 +1411,6 @@ void ceph_release_acl_sec_ctx(struct ceph_acl_sec_ctx *as_ctx) 
 * attributes are handled directly.

 */

const struct xattr_handler *ceph_xattr_handlers[] = {

#ifdef CONFIG_CEPH_FS_POSIX_ACL

	&posix_acl_access_xattr_handler,

	&posix_acl_default_xattr_handler,

#endif

	&ceph_other_xattr_handler,

	NULL,

};

fs/cifs/xattr.c

+0 −4
Original line number Diff line number Diff line
@@ -487,9 +487,5 @@ const struct xattr_handler *cifs_xattr_handlers[] = { 
	&smb3_ntsd_xattr_handler, /* alias for above since avoiding "cifs" */

	&cifs_cifs_ntsd_full_xattr_handler,

	&smb3_ntsd_full_xattr_handler, /* alias for above since avoiding "cifs" */

#ifdef CONFIG_FS_POSIX_ACL

	&posix_acl_access_xattr_handler,

	&posix_acl_default_xattr_handler,

#endif

	NULL

};

fs/ecryptfs/inode.c

+0 −4
Original line number Diff line number Diff line
@@ -1210,10 +1210,6 @@ static const struct xattr_handler ecryptfs_xattr_handler = { 
};



const struct xattr_handler *ecryptfs_xattr_handlers[] = {

#ifdef CONFIG_FS_POSIX_ACL

	&posix_acl_access_xattr_handler,

	&posix_acl_default_xattr_handler,

#endif

	&ecryptfs_xattr_handler,

	NULL

};