Unverified Commit 0ca52992 authored by Cezary Rojewski's avatar Cezary Rojewski Committed by Mark Brown
Browse files

ASoC: Intel: avs: Clearly state assumptions of hw_params() 



There are no NULL-checks for fe/be_hw_params as there is an implicit
assumption that framework opens valid DPCMs only. State that clearly.

Signed-off-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
Link: https://patch.msgid.link/20250109122216.3667847-9-cezary.rojewski@intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 94aa347d

sound/soc/intel/avs/pcm.c

+2 −0
Original line number Diff line number Diff line
@@ -161,6 +161,7 @@ static int avs_dai_be_hw_params(struct snd_pcm_substream *substream, 
	struct snd_soc_dpcm *dpcm;



	be = snd_soc_substream_to_rtd(substream);

	/* dpcm_fe_dai_open() guarantees the list is not empty at this point. */

	for_each_dpcm_fe(be, substream->stream, dpcm) {

		fe = dpcm->fe;

		fe_hw_params = &fe->dpcm[substream->stream].hw_params;
@@ -576,6 +577,7 @@ static int avs_dai_fe_hw_params(struct snd_pcm_substream *substream, 
	hdac_stream(host_stream)->format_val = 0;



	fe = snd_soc_substream_to_rtd(substream);

	/* dpcm_fe_dai_open() guarantees the list is not empty at this point. */

	for_each_dpcm_be(fe, substream->stream, dpcm) {

		be = dpcm->be;

		be_hw_params = &be->dpcm[substream->stream].hw_params;