Commit 0ca6755f authored by Aniruddha Paul's avatar Aniruddha Paul Committed by Tony Nguyen
Browse files

ice: Add a new counter for Rx EIPE errors 



HW incorrectly reports EIPE errors on encapsulated packets
with L2 padding inside inner packet. HW shows outer UDP/IPV4
packet checksum errors as part of the EIPE flags of the
Rx descriptor. These are reported only if checksum offload
is enabled and L3/L4 parsed flag is valid in Rx descriptor.

When that error is reported by HW, we don't act on it
instead of incrementing main Rx errors statistic as it
would normally happen.

Add a new statistic to count these errors since we still want
to print them.

Signed-off-by: default avatarAniruddha Paul <aniruddha.paul@intel.com>
Reviewed-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: default avatarJan Glaza <jan.glaza@intel.com>
Signed-off-by: default avatarJan Sokolowski <jan.sokolowski@intel.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent a292ba98

drivers/net/ethernet/intel/ice/ice.h

+1 −0
Original line number Diff line number Diff line
@@ -605,6 +605,7 @@ struct ice_pf { 
	wait_queue_head_t reset_wait_queue;



	u32 hw_csum_rx_error;

	u32 hw_rx_eipe_error;

	u32 oicr_err_reg;

	struct msi_map oicr_irq;	/* Other interrupt cause MSIX vector */

	struct msi_map ll_ts_irq;	/* LL_TS interrupt MSIX vector */

drivers/net/ethernet/intel/ice/ice_ethtool.c

+1 −0
Original line number Diff line number Diff line
@@ -129,6 +129,7 @@ static const struct ice_stats ice_gstrings_pf_stats[] = { 
	ICE_PF_STAT("rx_oversize.nic", stats.rx_oversize),

	ICE_PF_STAT("rx_jabber.nic", stats.rx_jabber),

	ICE_PF_STAT("rx_csum_bad.nic", hw_csum_rx_error),

	ICE_PF_STAT("rx_eipe_error.nic", hw_rx_eipe_error),

	ICE_PF_STAT("rx_dropped.nic", stats.eth.rx_discards),

	ICE_PF_STAT("rx_crc_errors.nic", stats.crc_errors),

	ICE_PF_STAT("illegal_bytes.nic", stats.illegal_bytes),

drivers/net/ethernet/intel/ice/ice_txrx_lib.c

+6 −2
Original line number Diff line number Diff line
@@ -143,8 +143,12 @@ ice_rx_csum(struct ice_rx_ring *ring, struct sk_buff *skb, 
	ipv6 = (decoded.outer_ip == ICE_RX_PTYPE_OUTER_IP) &&

	       (decoded.outer_ip_ver == ICE_RX_PTYPE_OUTER_IPV6);



	if (ipv4 && (rx_status0 & (BIT(ICE_RX_FLEX_DESC_STATUS0_XSUM_IPE_S) |

				   BIT(ICE_RX_FLEX_DESC_STATUS0_XSUM_EIPE_S))))

	if (ipv4 && (rx_status0 & (BIT(ICE_RX_FLEX_DESC_STATUS0_XSUM_EIPE_S)))) {

		ring->vsi->back->hw_rx_eipe_error++;

		return;

	}



	if (ipv4 && (rx_status0 & (BIT(ICE_RX_FLEX_DESC_STATUS0_XSUM_IPE_S))))

		goto checksum_fail;



	if (ipv6 && (rx_status0 & (BIT(ICE_RX_FLEX_DESC_STATUS0_IPV6EXADD_S))))