Commit 0cb2c504 authored by Joe Hattori's avatar Joe Hattori Committed by Paolo Abeni
Browse files

net: ethernet: bgmac-platform: fix an OF node reference leak 



The OF node obtained by of_parse_phandle() is not freed. Call
of_node_put() to balance the refcount.

This bug was found by an experimental static analysis tool that I am
developing.

Fixes: 1676aba5 ("net: ethernet: bgmac: device tree phy enablement")
Signed-off-by: default avatarJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20241214014912.2810315-1-joe@pf.is.s.u-tokyo.ac.jp


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 90d130aa

drivers/net/ethernet/broadcom/bgmac-platform.c

+4 −1
Original line number Diff line number Diff line
@@ -171,6 +171,7 @@ static int platform_phy_connect(struct bgmac *bgmac) 
static int bgmac_probe(struct platform_device *pdev)

{

	struct device_node *np = pdev->dev.of_node;

	struct device_node *phy_node;

	struct bgmac *bgmac;

	struct resource *regs;

	int ret;
@@ -236,7 +237,9 @@ static int bgmac_probe(struct platform_device *pdev) 
	bgmac->cco_ctl_maskset = platform_bgmac_cco_ctl_maskset;

	bgmac->get_bus_clock = platform_bgmac_get_bus_clock;

	bgmac->cmn_maskset32 = platform_bgmac_cmn_maskset32;

	if (of_parse_phandle(np, "phy-handle", 0)) {

	phy_node = of_parse_phandle(np, "phy-handle", 0);

	if (phy_node) {

		of_node_put(phy_node);

		bgmac->phy_connect = platform_phy_connect;

	} else {

		bgmac->phy_connect = bgmac_phy_connect_direct;