Commit 0cc4b846 authored by Aswin Karuvally's avatar Aswin Karuvally Committed by Paolo Abeni
Browse files

s390/ctcm: Use info level for handshake UC_RCRESET 



CTC adapter throws CTC_EVENT_UC_RCRESET (Unit check remote reset event)
during initial handshake, if the peer is not ready yet. This causes the
ctcm driver to re-attempt the handshake.

As it is normal for the event to occur during initialization, use info
instead of warn level in kernel log and NOTICE instead of ERROR level
in s390 debug feature. Also reword the log message for clarity.

Reviewed-by: default avatarAlexandra Winter <wintera@linux.ibm.com>
Signed-off-by: default avatarAswin Karuvally <aswin@linux.ibm.com>
Link: https://patch.msgid.link/20251103101652.2349855-1-aswin@linux.ibm.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent f47b0c11

drivers/s390/net/ctcm_fsms.c

+14 −0
Original line number Diff line number Diff line
@@ -882,6 +882,13 @@ static void ctcm_chx_rxiniterr(fsm_instance *fi, int event, void *arg) 
			fsm_newstate(fi, CTC_STATE_RXERR);

			fsm_event(priv->fsm, DEV_EVENT_RXDOWN, dev);

		}

	} else if (event == CTC_EVENT_UC_RCRESET) {

		CTCM_DBF_TEXT_(TRACE, CTC_DBF_NOTICE,

			       "%s(%s): %s in %s", CTCM_FUNTAIL, ch->id,

			       ctc_ch_event_names[event], fsm_getstate_str(fi));



		dev_info(&dev->dev,

			 "Init handshake not received, peer not ready yet\n");

	} else {

		CTCM_DBF_TEXT_(ERROR, CTC_DBF_ERROR,

			"%s(%s): %s in %s", CTCM_FUNTAIL, ch->id,
@@ -967,6 +974,13 @@ static void ctcm_chx_txiniterr(fsm_instance *fi, int event, void *arg) 
			fsm_newstate(fi, CTC_STATE_TXERR);

			fsm_event(priv->fsm, DEV_EVENT_TXDOWN, dev);

		}

	} else if (event == CTC_EVENT_UC_RCRESET) {

		CTCM_DBF_TEXT_(TRACE, CTC_DBF_NOTICE,

			       "%s(%s): %s in %s", CTCM_FUNTAIL, ch->id,

			       ctc_ch_event_names[event], fsm_getstate_str(fi));



		dev_info(&dev->dev,

			 "Init handshake not sent, peer not ready yet\n");

	} else {

		CTCM_DBF_TEXT_(ERROR, CTC_DBF_ERROR,

			"%s(%s): %s in %s", CTCM_FUNTAIL, ch->id,