Commit 0cc80943 authored by Ilan Peer's avatar Ilan Peer Committed by Johannes Berg
Browse files

wifi: mac80211_hwsim: Fix possible NULL dereference 



In a call to mac80211_hwsim_select_tx_link() the sta pointer might
be NULL, thus need to check that it is not NULL before accessing it.

Signed-off-by: default avatarIlan Peer <ilan.peer@intel.com>
Signed-off-by: default avatarGregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230604120651.f4d889fc98c4.Iae85f527ed245a37637a874bb8b8c83d79812512@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 15ddba5f

drivers/net/wireless/virtual/mac80211_hwsim.c

+2 −2
Original line number Diff line number Diff line
@@ -4,7 +4,7 @@ 
 * Copyright (c) 2008, Jouni Malinen <j@w1.fi>

 * Copyright (c) 2011, Javier Lopez <jlopex@gmail.com>

 * Copyright (c) 2016 - 2017 Intel Deutschland GmbH

 * Copyright (C) 2018 - 2022 Intel Corporation

 * Copyright (C) 2018 - 2023 Intel Corporation

 */



/*
@@ -1865,7 +1865,7 @@ mac80211_hwsim_select_tx_link(struct mac80211_hwsim_data *data, 


	WARN_ON(is_multicast_ether_addr(hdr->addr1));



	if (WARN_ON_ONCE(!sta->valid_links))

	if (WARN_ON_ONCE(!sta || !sta->valid_links))

		return &vif->bss_conf;



	for (i = 0; i < ARRAY_SIZE(vif->link_conf); i++) {