Commit 0cef1c32 authored by Marek Vasut's avatar Marek Vasut Committed by Jonathan Cameron
Browse files

iio: light: noa1305: Simplify noa1305_read_raw() 



The only channel this hardware supports is IIO_LIGHT, if the channel
is anything else, exit right away. The 'ret' variable is now always
only assigned by noa1305_measure(), do not initialize it anymore.
Update function parameter indent. No functional change.

Signed-off-by: default avatarMarek Vasut <marex@denx.de>
Link: https://patch.msgid.link/20240715183120.143417-1-marex@denx.de


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent d5cbe150

drivers/iio/light/noa1305.c

+13 −24
Original line number Diff line number Diff line
@@ -128,35 +128,24 @@ static int noa1305_read_raw(struct iio_dev *indio_dev, 
			    struct iio_chan_spec const *chan,

			    int *val, int *val2, long mask)

{

	int ret = -EINVAL;

	struct noa1305_priv *priv = iio_priv(indio_dev);

	int ret;



	if (chan->type != IIO_LIGHT)

		return -EINVAL;



	switch (mask) {

	case IIO_CHAN_INFO_RAW:

		switch (chan->type) {

		case IIO_LIGHT:

		ret = noa1305_measure(priv);

		if (ret < 0)

			return ret;

		*val = ret;

		return IIO_VAL_INT;

		default:

			break;

		}

		break;

	case IIO_CHAN_INFO_SCALE:

		switch (chan->type) {

		case IIO_LIGHT:

		return noa1305_scale(priv, val, val2);

	default:

			break;

		}

		break;

	default:

		break;

		return -EINVAL;

	}



	return ret;

}



static const struct iio_info noa1305_info = {