Commit 0cf9c58b authored by Milos Nikic's avatar Milos Nikic Committed by Jan Kara
Browse files

ext2: replace BUG_ON with WARN_ON_ONCE in ext2_get_blocks 



If ext2_get_blocks() is called with maxblocks == 0, it currently triggers
a BUG_ON(), causing a kernel panic.

While this condition implies a logic error in the caller, a filesystem
should not crash the system due to invalid arguments.

Replace the BUG_ON() with a WARN_ON_ONCE() to provide a stack trace for
debugging, and return -EINVAL to handle the error gracefully.

Signed-off-by: default avatarMilos Nikic <nikic.milos@gmail.com>
Link: https://patch.msgid.link/20260207010617.216675-1-nikic.milos@gmail.com


Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent 6d942c87

fs/ext2/inode.c

+2 −1
Original line number Diff line number Diff line
@@ -638,7 +638,8 @@ static int ext2_get_blocks(struct inode *inode, 
	int count = 0;

	ext2_fsblk_t first_block = 0;



	BUG_ON(maxblocks == 0);

	if (WARN_ON_ONCE(maxblocks == 0))

		return -EINVAL;



	depth = ext2_block_to_path(inode,iblock,offsets,&blocks_to_boundary);