Unverified Commit 0d15ce31 authored by Johan Hovold's avatar Johan Hovold Committed by Mark Brown
Browse files

regulator: act8945a: fix OF node reference imbalance 



The driver reuses the OF node of the parent multi-function device but
fails to take another reference to balance the one dropped by the
platform bus code when unbinding the MFD and deregistering the child
devices.

Fix this by using the intended helper for reusing OF nodes.

Fixes: 38c09961 ("regulator: act8945a: add regulator driver for ACT8945A")
Cc: stable@vger.kernel.org	# 4.6
Cc: Wenyou Yang <wenyou.yang@atmel.com>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260408073055.5183-7-johan@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent ebe694d6

drivers/regulator/act8945a-regulator.c

+2 −1
Original line number Diff line number Diff line
@@ -302,8 +302,9 @@ static int act8945a_pmic_probe(struct platform_device *pdev) 
		num_regulators = ARRAY_SIZE(act8945a_regulators);

	}



	device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent);



	config.dev = &pdev->dev;

	config.dev->of_node = pdev->dev.parent->of_node;

	config.driver_data = act8945a;

	for (i = 0; i < num_regulators; i++) {

		rdev = devm_regulator_register(&pdev->dev, &regulators[i],