Commit 0d195d3b authored by Christoph Böhmwalder's avatar Christoph Böhmwalder Committed by Jens Axboe
Browse files

drbd: fix null-pointer dereference on local read error 



In drbd_request_endio(), READ_COMPLETED_WITH_ERROR is passed to
__req_mod() with a NULL peer_device:

  __req_mod(req, what, NULL, &m);

The READ_COMPLETED_WITH_ERROR handler then unconditionally passes this
NULL peer_device to drbd_set_out_of_sync(), which dereferences it,
causing a null-pointer dereference.

Fix this by obtaining the peer_device via first_peer_device(device),
matching how drbd_req_destroy() handles the same situation.

Cc: stable@vger.kernel.org
Reported-by: default avatarTuo Li <islituo@gmail.com>
Link: https://lore.kernel.org/linux-block/20260104165355.151864-1-islituo@gmail.com


Signed-off-by: default avatarChristoph Böhmwalder <christoph.boehmwalder@linbit.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 81b1f046

drivers/block/drbd/drbd_req.c

+2 −1
Original line number Diff line number Diff line
@@ -621,7 +621,8 @@ int __req_mod(struct drbd_request *req, enum drbd_req_event what, 
		break;



	case READ_COMPLETED_WITH_ERROR:

		drbd_set_out_of_sync(peer_device, req->i.sector, req->i.size);

		drbd_set_out_of_sync(first_peer_device(device),

				req->i.sector, req->i.size);

		drbd_report_io_error(device, req);

		__drbd_chk_io_error(device, DRBD_READ_ERROR);

		fallthrough;