Commit 0d1c18a1 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Jakub Kicinski
Browse files

net: stmmac: qcom-ethqos: remove speed_mode_2500() method 



qcom-ethqos doesn't need to implement the speed_mode_2500() method as
it is only setting priv->plat->phy_interface to 2500BASE-X, which is
already a pre-condition for assigning speed_mode_2500 in
qcom_ethqos_probe(). So, qcom_ethqos_speed_mode_2500() has no effect.
Remove it.

Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/E1u3bYa-000EcW-H1@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 4c30093f

drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c

+0 −9
Original line number Diff line number Diff line
@@ -672,13 +672,6 @@ static int ethqos_configure_sgmii(struct qcom_ethqos *ethqos, int speed) 
	return val;

}



static void qcom_ethqos_speed_mode_2500(struct net_device *ndev, void *data)

{

	struct stmmac_priv *priv = netdev_priv(ndev);



	priv->plat->phy_interface = PHY_INTERFACE_MODE_2500BASEX;

}



static int ethqos_configure(struct qcom_ethqos *ethqos, int speed)

{

	return ethqos->configure_func(ethqos, speed);
@@ -800,8 +793,6 @@ static int qcom_ethqos_probe(struct platform_device *pdev) 
		ethqos->configure_func = ethqos_configure_rgmii;

		break;

	case PHY_INTERFACE_MODE_2500BASEX:

		plat_dat->speed_mode_2500 = qcom_ethqos_speed_mode_2500;

		fallthrough;

	case PHY_INTERFACE_MODE_SGMII:

		ethqos->configure_func = ethqos_configure_sgmii;

		break;