Commit 0d3bf53e authored by Sergey Shtylyov's avatar Sergey Shtylyov Committed by Wolfram Sang
Browse files

i2c: mlxbf: add IRQ check 



The driver neglects to check the result of platform_get_irq()'s call and
blithely passes the negative error codes to devm_request_irq() (which
takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding
an original error code.  Stop calling devm_request_irq() with invalid
IRQ #s.

Fixes: b5b5b320 ("i2c: mlxbf: I2C SMBus driver for Mellanox BlueField SoC")
Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omprussia.ru>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent c5e5f7a8

drivers/i2c/busses/i2c-mlxbf.c

+2 −0
Original line number Diff line number Diff line
@@ -2370,6 +2370,8 @@ static int mlxbf_i2c_probe(struct platform_device *pdev) 
	mlxbf_i2c_init_slave(pdev, priv);



	irq = platform_get_irq(pdev, 0);

	if (irq < 0)

		return irq;

	ret = devm_request_irq(dev, irq, mlxbf_smbus_irq,

			       IRQF_ONESHOT | IRQF_SHARED | IRQF_PROBE_SHARED,

			       dev_name(dev), priv);