Commit 0d5cb730 authored by Jack Xu's avatar Jack Xu Committed by Herbert Xu
Browse files

crypto: qat - remove redundant FW image size check 



The FW image size check is already performed in the function
qat_uclo_check_image() before calling `qat_uclo_map_auth_fw()`.
Therefore, the additional check in `qat_uclo_map_auth_fw()` is redundant
and can be safely removed.

Signed-off-by: default avatarJack Xu <jack.xu@intel.com>
Reviewed-by: default avatarAhsan Atta <ahsan.atta@intel.com>
Reviewed-by: default avatarGiovanni Cabiddu <giovanni.cabiddu@intel.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarGiovanni Cabiddu <giovanni.cabiddu@intel.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent bd2c6e0e

drivers/crypto/intel/qat/qat_common/qat_uclo.c

+0 −4
Original line number Diff line number Diff line
@@ -1418,10 +1418,6 @@ static int qat_uclo_map_auth_fw(struct icp_qat_fw_loader_handle *handle, 
	struct icp_qat_simg_ae_mode *simg_ae_mode;

	struct icp_firml_dram_desc img_desc;



	if (size > (ICP_QAT_AE_IMG_OFFSET(handle) + ICP_QAT_CSS_RSA4K_MAX_IMAGE_LEN)) {

		pr_err("QAT: error, input image size overflow %d\n", size);

		return -EINVAL;

	}

	length = (css_hdr->fw_type == CSS_AE_FIRMWARE) ?

		 ICP_QAT_CSS_AE_SIMG_LEN(handle) + simg_offset :

		 size + ICP_QAT_CSS_FWSK_PAD_LEN(handle) + simg_offset;