Unverified Commit 0d62c64a authored by Théo Lebrun's avatar Théo Lebrun Committed by Mark Brown
Browse files

spi: cadence-qspi: assert each subnode flash CS is valid 



Check each flash CS against the num-cs property from devicetree.
Fallback to the driver max supported value (CQSPI_MAX_CHIPSELECT) if
num-cs isn't present.

cqspi->num_chipselect is set in cqspi_of_get_pdata() to the num-cs
devicetree property, or to CQSPI_MAX_CHIPSELECT if num-cs is not set.

Signed-off-by: default avatarThéo Lebrun <theo.lebrun@bootlin.com>
Reviewed-by: default avatarDhruva Gole <d-gole@ti.com>
Link: https://msgid.link/r/20240209-cdns-qspi-cs-v1-1-a4f9dfed9ab4@bootlin.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent afd2a4ae

drivers/spi/spi-cadence-quadspi.c

+1 −1
Original line number Diff line number Diff line
@@ -1635,7 +1635,7 @@ static int cqspi_setup_flash(struct cqspi_st *cqspi) 
			return ret;

		}



		if (cs >= CQSPI_MAX_CHIPSELECT) {

		if (cs >= cqspi->num_chipselect) {

			dev_err(dev, "Chip select %d out of range.\n", cs);

			of_node_put(np);

			return -EINVAL;