Commit 0d7c2194 authored by Sascha Hauer's avatar Sascha Hauer Committed by Kalle Valo
Browse files

wifi: mwifiex: add missing locking for cfg80211 calls 



cfg80211_rx_assoc_resp() and cfg80211_rx_mlme_mgmt() need to be called
with the wiphy locked, so lock it before calling these functions.

Fixes: 36995892 ("wifi: mwifiex: add host mlme for client mode")
Reviewed-by: default avatarFrancesco Dolcini <francesco.dolcini@toradex.com>
Signed-off-by: default avatarSascha Hauer <s.hauer@pengutronix.de>
Acked-by: default avatarBrian Norris <briannorris@chromium.org>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/20240918-mwifiex-cleanup-1-v2-1-2d0597187d3c@pengutronix.de
parent 5ab202f2

drivers/net/wireless/marvell/mwifiex/cmdevt.c

+2 −0
Original line number Diff line number Diff line
@@ -938,8 +938,10 @@ void mwifiex_process_assoc_resp(struct mwifiex_adapter *adapter) 
		assoc_resp.links[0].bss = priv->req_bss;

		assoc_resp.buf = priv->assoc_rsp_buf;

		assoc_resp.len = priv->assoc_rsp_size;

		wiphy_lock(priv->wdev.wiphy);

		cfg80211_rx_assoc_resp(priv->netdev,

				       &assoc_resp);

		wiphy_unlock(priv->wdev.wiphy);

		priv->assoc_rsp_size = 0;

	}

}

drivers/net/wireless/marvell/mwifiex/util.c

+2 −0
Original line number Diff line number Diff line
@@ -494,7 +494,9 @@ mwifiex_process_mgmt_packet(struct mwifiex_private *priv, 
			}

		}



		wiphy_lock(priv->wdev.wiphy);

		cfg80211_rx_mlme_mgmt(priv->netdev, skb->data, pkt_len);

		wiphy_unlock(priv->wdev.wiphy);

	}



	if (priv->adapter->host_mlme_enabled &&