Commit 0dcc53ab authored by Su Hui's avatar Su Hui Committed by Paolo Abeni
Browse files

net: ethtool: fix the error condition in ethtool_get_phy_stats_ethtool() 



Clang static checker (scan-build) warning:
net/ethtool/ioctl.c:line 2233, column 2
Called function pointer is null (null dereference).

Return '-EOPNOTSUPP' when 'ops->get_ethtool_phy_stats' is NULL to fix
this typo error.

Fixes: 201ed315 ("net/ethtool/ioctl: split ethtool_get_phy_stats into multiple helpers")
Signed-off-by: default avatarSu Hui <suhui@nfschina.com>
Reviewed-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: default avatarHariprasad Kelam <hkelam@marvell.com>
Link: https://lore.kernel.org/r/20240605034742.921751-1-suhui@nfschina.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent b01e1c03

net/ethtool/ioctl.c

+1 −1
Original line number Diff line number Diff line
@@ -2220,7 +2220,7 @@ static int ethtool_get_phy_stats_ethtool(struct net_device *dev, 
	const struct ethtool_ops *ops = dev->ethtool_ops;

	int n_stats, ret;



	if (!ops || !ops->get_sset_count || ops->get_ethtool_phy_stats)

	if (!ops || !ops->get_sset_count || !ops->get_ethtool_phy_stats)

		return -EOPNOTSUPP;



	n_stats = ops->get_sset_count(dev, ETH_SS_PHY_STATS);