Commit 0ddd3bb4 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Linus Walleij
Browse files

drm/pl111: Fix error handling in pl111_amba_probe 



Jump to the existing dev_put label when devm_request_irq() fails
so drm_dev_put() and of_reserved_mem_device_release() run
instead of returning early and leaking resources.

Found via static analysis and code review.

Fixes: bed41005 ("drm/pl111: Initial drm/kms driver for pl111")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Signed-off-by: default avatarLinus Walleij <linusw@kernel.org>
Link: https://patch.msgid.link/20251211123345.2392065-1-linmq006@gmail.com
parent 3fbd9761

drivers/gpu/drm/pl111/pl111_drv.c

+1 −1
Original line number Diff line number Diff line
@@ -295,7 +295,7 @@ static int pl111_amba_probe(struct amba_device *amba_dev, 
			       variant->name, priv);

	if (ret != 0) {

		dev_err(dev, "%s failed irq %d\n", __func__, ret);

		return ret;

		goto dev_put;

	}



	ret = pl111_modeset_init(drm);